Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation fixes #48

Closed
wants to merge 2 commits into from
Closed

Validation fixes #48

wants to merge 2 commits into from

Conversation

SLaks
Copy link

@SLaks SLaks commented Nov 27, 2012

I fixed two issues with CSS property value validation:

  • Allow border-bottom-color: inherit
  • Require units for <length> values

I didn't check to make sure that there aren't any properties that only allow <length> and should also allow <integer> or <number>.

@SLaks
Copy link
Author

SLaks commented Nov 27, 2012

I didn't include an ant build; if you want to, I can add another commit with that.

@nzakas
Copy link
Contributor

nzakas commented Mar 9, 2013

I don't agree with the change to not allow unit-less values, so I'm not able to merge this in. In the future, please limit each pull request to one fix, that way I can merge in what I want and not have to either take or leave the entire thing.

@nzakas nzakas closed this Mar 9, 2013
@SLaks
Copy link
Author

SLaks commented Mar 10, 2013

Why? Unit-less lengths are not valid per the CSS specs. (although older IEs did support them)

@nzakas
Copy link
Contributor

nzakas commented Mar 10, 2013

Well, you yourself mentioned that you didn't do any research to figure out
if this change would break any existing behavior, so I'm not confident that
the change is correct. I'm not in favor of changing things that seem wrong
without understanding a) if it was causing a bug before and b) what are the
effects if the code is changed.

On Sat, Mar 9, 2013 at 4:43 PM, SLaks notifications@github.com wrote:

Why? Unit-less lengths are not valid per the CSS specs. (although older
IEs did support them)


Reply to this email directly or view it on GitHubhttps://github.com//pull/48#issuecomment-14673853
.


Nicholas C. Zakas
@SlickNet

Author, Professional JavaScript for Web Developers
Buy it at Amazon.com:
http://www.amazon.com/Professional-JavaScript-Developers-Nicholas-Zakas/dp/1118026691/ref=sr_1_3

SLaks added a commit to SLaks/Styliner that referenced this pull request Sep 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants