Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

Don't write beyond buffer when reading a signature #386

Merged
merged 1 commit into from Jun 10, 2017
Merged

Don't write beyond buffer when reading a signature #386

merged 1 commit into from Jun 10, 2017

Conversation

sinic
Copy link
Contributor

@sinic sinic commented Jun 1, 2017

No description provided.

@hugbug
Copy link
Member

hugbug commented Jun 1, 2017

Thanks.
I wonder how did you catch this, did it crash for you during update? Have I uploaded bad signature file? What is your OS (more specifically which one signature was longer than expected)?

@sinic
Copy link
Contributor Author

sinic commented Jun 1, 2017

No, I was just reading the code.

@hugbug
Copy link
Member

hugbug commented Jun 1, 2017

Cool.
I'll need to test the update function before merging; it will take some time.
Thanks again.

@hugbug hugbug merged commit 7793f64 into nzbget:develop Jun 10, 2017
@sinic
Copy link
Contributor Author

sinic commented Jun 11, 2017

Any plans for a release? I have a PoC that gets an attacker from MitM to RCE, so this is rather serious.

@hugbug
Copy link
Member

hugbug commented Jun 11, 2017

The fix will be released with v19, in the next couple of weeks.

When you talk about attack you don't mean through nzbget? Such attack would work only during update procedure via web-interface, which is a rare thing. And if you concerned you can update manually.

@sinic
Copy link
Contributor Author

sinic commented Jun 11, 2017

Yes, I was only talking about the web-interface.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants