Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Climate Cleanup in hass 0.96 Breaking change #15

Closed
MuppetOwl opened this issue Jul 11, 2019 · 7 comments
Closed

Climate Cleanup in hass 0.96 Breaking change #15

MuppetOwl opened this issue Jul 11, 2019 · 7 comments

Comments

@MuppetOwl
Copy link
Contributor

MuppetOwl commented Jul 11, 2019

@o0Zz
Component need to be updated to work with version 0.96 releasing this week. Multiple breaking changes

https://developers.home-assistant.io/blog/2019/07/03/climate-cleanup.html
home-assistant/core#23899

@dolenec
Copy link

dolenec commented Jul 16, 2019

Is there any news regarding component update?

@o0Zz
Copy link
Owner

o0Zz commented Jul 16, 2019

Hi,

I'm working on it. I will need probably more time to integrate the changes but it's in progress. I will keep you updated in this ticket.

BR

@mgosk
Copy link

mgosk commented Jul 18, 2019

Do you have list of things to fix ? I'm not very familiar with python, but I will try to help :)

@o0Zz
Copy link
Owner

o0Zz commented Jul 21, 2019

I updated this component to be compatible with new HA v0.96. Please have a look and let me know if everything is correct.

@o0Zz o0Zz closed this as completed Jul 21, 2019
@MuppetOwl
Copy link
Contributor Author

MuppetOwl commented Jul 21, 2019

Thanks @o0Zz
I updated now.

A few errors

  • only show one heatpump. I have two. It worked for both before. Any changes that may have broken that? I see both in Melcloud app.

  • error when trying to select Dry, cool, fan and auto. Heat and off is the only one that works.

Failed to call service climate/set_hvac_mode. name 'OPERATION_COOL_STR' is not defined
Name 'OPERATION_COOL_STR' is not defined

File "/config/custom_components/melcloud/climate.py", line 453, in hvac_mode
return OPERATION_DRY_STR
NameError: name 'OPERATION_DRY_STR' is not defined

Edit: Found a few errors in the code where old operations mode was not changed to HVAC_MODE_. After fixing the dry, cool functions etc both heatpumps loads correct.

@EDV11
Copy link

EDV11 commented Jul 23, 2019

@oOZz

Thanks for your work

@CookieMonster87

Care to share your updated files?

Thanks

@MuppetOwl
Copy link
Contributor Author

Updated changes is already applied. I created a pull request that o0Zz added to the latest version of the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants