Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better and more ASCII !! (╯°□°)╯︵ ┻━┻ #105

Closed
o2sh opened this issue Oct 23, 2019 · 5 comments
Closed

Better and more ASCII !! (╯°□°)╯︵ ┻━┻ #105

o2sh opened this issue Oct 23, 2019 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed pinned

Comments

@o2sh
Copy link
Owner

o2sh commented Oct 23, 2019

Some of our ascii logos look a bit out of shape...

plz help ಥ_ಥ

Don't hesitate to add more languages, if you feel inspired 💯

@o2sh o2sh added enhancement New feature or request help wanted Extra attention is needed hacktoberfest labels Oct 23, 2019
@o2sh o2sh pinned this issue Oct 23, 2019
@o2sh o2sh removed the hacktoberfest label Nov 1, 2019
@stale
Copy link

stale bot commented Aug 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 21, 2020
@o2sh o2sh added pinned and removed wontfix labels Aug 21, 2020
@spenserblack
Copy link
Collaborator

spenserblack commented Sep 3, 2020

Per #204, we don't really have a uniform height/width, so some ASCII can be pretty large. The ASCII probably don't have to all be exactly the same, but we should probably pick a target maximum. For me personally, I use a vertical monitor, so the Lua ASCII takes up so much horizontal space that it messes up printing of languages in multi-language projects. I think 25x25 might be a reasonable target for maximum dimensions, what do you think?

Once we pick out max dimensions, I'll write a test to walk over the ASCII and enforce those dimensions.

@spenserblack spenserblack mentioned this issue Sep 3, 2020
@o2sh
Copy link
Owner Author

o2sh commented Sep 3, 2020

Yes, Lua's ascii logo is way too big.

The ASCII probably don't have to all be exactly the same, but we should probably pick a target maximum.

Definitely, setting clear guidelines for new language support is the right way to go. In the same spirit, I created #205 to facilitate the work of new contributors. Once done, I'll add a specific paragraph in the CONTRIBUTING.md called Adding support for a new Language.

I think 25x25 might be a reasonable target for maximum dimensions, what do you think?

The width may be too short, I don't think we have a lot of ascii logos hat fall inside those dimensions. Maybe 25*40.

Once we pick out max dimensions, I'll write a test to walk over the ASCII and enforce those dimensions.

Yes, having a test we can include in CI would be great.

@spenserblack
Copy link
Collaborator

spenserblack commented Sep 3, 2020

25*40

Sounds good to me! Just to clarify: you're using the format h*w?

@o2sh
Copy link
Owner Author

o2sh commented Sep 3, 2020

Yes.

@o2sh o2sh closed this as completed Oct 6, 2020
@o2sh o2sh reopened this Oct 6, 2020
@o2sh o2sh closed this as completed Nov 7, 2020
@o2sh o2sh unpinned this issue Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed pinned
Projects
None yet
Development

No branches or pull requests

2 participants