-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to exclude files from churn #1091
Comments
Sorry for requesting something that will require a refactor to pass around the config so soon after a release 馃槩 |
No worries! The reason why I was so eager to push a new release was to get feedback, which seems to be working 馃槃
That's a great idea, and I agree that it should behave the same way as the
I don't know, maybe we could decouple the two and explain the difference between them in a help message, or by finding a more specific name. Some users may want to exclude certain files/folders from the churn while still having them taken into account in the language distribution 馃 |
Sounds good to me! That was my initial instinct, but then I had trouble thinking of a real-world example where I'd want to exclude files from churn metrics but include them for everything else, since my use case is generated files. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Summary 馃挕
Nice to see this feature in action!
Proposing an option
--churn-exclude
to exclude certain files from the churn metrics. To pair with--exclude
, it should probably take 1 or more glob patterns in the format--churn-exclude '**.foo' 'assets/*.png'
Alternatively,
--exclude
can be used to ignore files for churn metrics. Some users might be surprised to--exclude
a file and still see it in the churn metric.Motivation 馃敠
When trying out this new feature, I noticed that
.snap
files for snapshot tests were getting picked up. These can be expected to change a lot, and as a result it's not necessarily useful to see a churn metric for these files. The same is probably true for other generated assets. So it might be useful to be able to ignore certain files.The text was updated successfully, but these errors were encountered: