Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce size of Nim's ASCII logo #250

Closed
o2sh opened this issue Oct 9, 2020 · 4 comments
Closed

Reduce size of Nim's ASCII logo #250

o2sh opened this issue Oct 9, 2020 · 4 comments
Assignees
@tianlangwu
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@o2sh
Copy link
Owner

o2sh commented Oct 9, 2020

Some of our ASCII logos exceed the max size imposed by our Guideline. The Nim's ASCII logo is one of them:

nim

The idea would be to come up with a new ASCII logo for Nim with a width < MAX_WIDTH = 40 and height < MAX_HEIGHT = 25

To check if your ASCII logo falls into the boundaries of width/height defined above, you can run cargo test -- --ignored
@o2sh o2sh added help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 9, 2020
@tianlangwu
Copy link
Contributor

Do you want a size down of this logo or a completely new logo for Nim's ASCII? I am not a creative person >.<. Can you assign this to me if you would like to just size down the logo :D.

@o2sh
Copy link
Owner Author

o2sh commented Oct 9, 2020

Can you assign this to me if you would like to just size down the logo

Sure, go ahead 👍

@tianlangwu
Copy link
Contributor

tianlangwu commented Oct 9, 2020 •
edited

Do you think this is ok?
logo

It passed the test, but I am not sure you satisfied with it.
nim

I also have some other version with little adjustments but I don't know which one is better.
nim2

nim3

I am going to send the pull request if you think this is ok.

@o2sh
Copy link
Owner Author

o2sh commented Oct 9, 2020 •
edited

Looks perfect!

Looking forward to merge your PR

@tianlangwu tianlangwu mentioned this issue Oct 9, 2020
Merged
@o2sh o2sh closed this as completed Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tianlangwu tianlangwu

Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@o2sh @tianlangwu