Support colors when using custom ascii image (--ascii-input option)

[Pomroka]

Using --ascii-colors don't affect my image, only text.

[spenserblack]

Looks like an empty Vec is currently getting passed as the colors when custom ASCII art is used.

onefetch/src/ui/printer.rs

Lines 41 to 65 in 3a1368a

	let colors: Vec<Color> = Vec::new();
	let mut buf = String::new();
	if self.info.config.art_off {
	buf.push_str(&info_str);
	} else if let Some(custom_image) = &self.info.config.image {
	let image_backend = self
	.info
	.config
	.image_backend
	.as_ref()
	.with_context(|| "Could not detect a supported image backend")?;
	buf.push_str(
	&image_backend
	.add_image(
	info_lines.map(|s| format!("{}{}", center_pad, s)).collect(),
	custom_image,
	self.info.config.image_color_resolution,
	)
	.with_context(|| "Error while drawing image")?,
	);
	} else {
	let mut logo_lines = if let Some(custom_ascii) = &self.info.config.ascii_input {
	AsciiArt::new(custom_ascii, &colors, !self.info.config.no_bold)

[spenserblack]

In fact, the current behavior is that colors are effectively disabled when using custom ascii art.

I'll change the title to reflect that we need to make a change to support this.

(not 100% sure if this qualifies as a bug report or a feature request 🤷)

[o2sh]

NGL, it never crossed my mind to combine the two flags --ascii-colors and --ascii-input together 😅

It shouldn't be too hard to make it work 👍

[Pomroka]

As i didn't find a way to load custom ascii image directly i used --ascii-input and when i saw no color i try use only logical option i found.
Load custom ascii logo from file would be my another Feature Request

[spenserblack]

Load custom ascii logo from file

Until that feature is implemented I think that onefetch --ascii-input "$(cat my-ascii-art-file)" would work.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[o2sh]

@Pomroka with #680, it should work as expected.
If you agree, don't forget to close the issue.

[Pomroka]

👍