Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset Browser: Support Undo for file deletion, or always show a confirmation dialog #13488

Closed
jckand opened this issue Dec 1, 2022 · 2 comments · Fixed by #15265
Closed

Asset Browser: Support Undo for file deletion, or always show a confirmation dialog #13488

jckand opened this issue Dec 1, 2022 · 2 comments · Fixed by #15265
Assignees
Labels
feature/asset-browser This item is related to the asset-browser subsystem. priority/major Major priority. Work that should be handled after all blocking and critical work is done. sig/content Categorizes an issue or PR as relevant to SIG Content. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@jckand
Copy link
Contributor

jckand commented Dec 1, 2022

Is your feature request related to a problem? Please describe.
It is very easy to delete a file from the Asset Browser, potentially even inadvertently with the Delete key or via context menu with an unintended asset selected. If this is done, and there are no references found to the asset, the file is simply deleted with no way to get it back.

Describe the solution you'd like
Support Undo for file deletions, or at least always show a confirmation dialog (potentially with a toggle box to hide in the future) with a warning that it's an irreversible action.

Describe alternatives you've considered
Being very precise about what files to delete.

@jckand jckand added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/content Categorizes an issue or PR as relevant to SIG Content. feature/asset-browser This item is related to the asset-browser subsystem. labels Dec 1, 2022
@rainbj
Copy link

rainbj commented Dec 17, 2022

Delete files

Ideally, we would like to support both workflows. However, In this image, I have given both option if we are unable to support undo file deletion.

@rainbj
Copy link

rainbj commented Dec 17, 2022

@micronAMZN and @chanmosq - Please let me know if my text works for you or if you have further suggestions to refine the copy.

@monroegm monroegm added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/major Major priority. Work that should be handled after all blocking and critical work is done. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 5, 2023
@dtamkin1 dtamkin1 self-assigned this Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/asset-browser This item is related to the asset-browser subsystem. priority/major Major priority. Work that should be handled after all blocking and critical work is done. sig/content Categorizes an issue or PR as relevant to SIG Content. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants