Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physics Material System Improvements #2897

Closed
1 task done
ghost opened this issue Aug 5, 2021 · 5 comments
Closed
1 task done

Physics Material System Improvements #2897

ghost opened this issue Aug 5, 2021 · 5 comments
Labels
feature/physics This item is related to the physics subsystem. kind/roadmap Categorizes an issue that goes in the O3DE Public Roadmap sig/simulation Categorizes an issue or PR as relevant to SIG Simulation

Comments

@ghost
Copy link

ghost commented Aug 5, 2021

Description

The way physics material assets are stored and used will be completely updated. The physics material library asset will be removed and we will support individual physics material assets, much like render materials and other assets in O3DE. This will make working with physics materials much easier and more consistent.

  • Remove physics material library and support individual physics assets

Status

Complete

@ghost ghost added feature/physics This item is related to the physics subsystem. sig/core Categorizes an issue or PR as relevant to SIG Core kind/story Story: Short requirements or requests written from the perspective of an end user labels Aug 5, 2021
@AMZN-Liv AMZN-Liv added this to Proposed in O3DE Roadmap Aug 5, 2021
@hultonha hultonha added sig/simulation Categorizes an issue or PR as relevant to SIG Simulation and removed sig/core Categorizes an issue or PR as relevant to SIG Core labels May 3, 2022
@hultonha hultonha changed the title Physics Material System Foundation Physics Material System Improvements Jul 14, 2022
@hultonha hultonha added status/active Indicates that an issue or PR is actively being worked on by a contributor. kind/roadmap Categorizes an issue that goes in the O3DE Public Roadmap and removed kind/story Story: Short requirements or requests written from the perspective of an end user labels Jul 14, 2022
@hultonha
Copy link
Contributor

Aside: We updated this ticket to better reflect recent physics work - please see original ticket details that have been migrated to #12077.

@moraaar
Copy link
Contributor

moraaar commented Sep 20, 2022

PhysX Material refactor work to remove physics material library was submitted by the following PR:

The same refactor was done for blast materials:

@moraaar
Copy link
Contributor

moraaar commented Sep 20, 2022

[Impactful Change] Physics material refactor

What’s changing?
Physics material assets are now managed independently. The concept of physics material library has been removed and now one asset is one physics material. A physics material is created using Asset Editor tool.

Why is this change being made?
To simplify the workflow of authoring and using physics materials, we're making it more like how render materials work. Having a library asset added an extra layer of complexity that users had to deal with and learn how to use within the editor. Now physics materials can be assigned to collider components directly like any other asset.

When is this change coming to development?
Change was merged into development on June 8th 2022 #9856 and released with O3DE 2022.10.0

What actions will I need to take?
If you work with AutomatedTesting, atomtest, atom-sampleviewer, multiplatyersample or netsoaktest, you don’t need to do anything, all physics material assets will be converted already.

For any other project, one person will need to convert assets following these steps:

  1. Run Editor. Do not open any level, just close the "Welcome to O3DE" screen.
  2. Wait until Asset Processor has finished processing all the assets
  3. Open Console: Tools > Console
  4. Enter the following console command to convert old physics material libraries: "ed_physxConvertMaterialLibrariesIntoIndividualMaterials"
  5. Wait until Asset Processor has finished processing all the assets
  6. Enter the following console command to fix prefabs and fbx manifests that reference old assets: "ed_physxFixAssetsUsingPhysicsLegacyMaterials"
  7. Wait until Asset Processor has finished processing all the assets
  8. Commit the source assets changes into Github.

What components are affected by this change?
Physics materials are used in the following places:

  • PhysX Collider Component
  • PhysX Shape Collider Component
  • PhysX Character Controller Component
  • PhysX Terrain Heightfield Collider Component
  • Terrain Heightfield Component
  • Blast Family Component
  • Actor’s Ragdoll Collider in FBX manifest
  • Actor’s Hit Detection Collider in FBX manifest
  • PhysX Mesh Group in FBX manifest
  • White Box Collider

@hultonha
Copy link
Contributor

Note: This issue is related to this feature that we might want to look at resolving when returning to this - #12503

@moraaar moraaar removed their assignment Mar 14, 2023
@hultonha hultonha removed the status/active Indicates that an issue or PR is actively being worked on by a contributor. label Mar 14, 2023
@hultonha hultonha removed their assignment Mar 14, 2023
@hultonha
Copy link
Contributor

Please see tangentially related follow-on work here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/physics This item is related to the physics subsystem. kind/roadmap Categorizes an issue that goes in the O3DE Public Roadmap sig/simulation Categorizes an issue or PR as relevant to SIG Simulation
Projects
Archived in project
Development

No branches or pull requests

2 participants