Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add a Global Ambient Lighting component #3385

Open
LB-ArturZieba opened this issue Aug 23, 2021 · 2 comments
Open

Feature Request: Add a Global Ambient Lighting component #3385

LB-ArturZieba opened this issue Aug 23, 2021 · 2 comments
Labels
feature/graphics This item is related to the Atom renderer or graphics. good-first-issue Issue ready for a new contributor according to the help wanted guidelines. kind/story Story: Short requirements or requests written from the perspective of an end user priority/minor Lowest priority. Work that may be scheduled sig/graphics-audio Categorizes an issue or PR as relevant to SIG graphics-audio.

Comments

@LB-ArturZieba
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The only available convenient way to create global illumination is to use the Global Skylight (IBL) component.

Describe the solution you'd like
A standalone component or an option on the Light component for global ambient lighting, with parameters such as color and intensity built into it.

Describe alternatives you've considered
An easy, in-engine way of creating skyboxes that comply with the Global Skylight (IBL) component.

Additional context
Currently the only convenient way of creating a global ambient lighting is using the Global Skylight (IBL) component with an empty Specular Image parameter and white_latlong_iblskyboxcm_ibldiffuse.exr assigned to the Diffuse Image parameter.

@LB-ArturZieba LB-ArturZieba added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/minor Lowest priority. Work that may be scheduled kind/story Story: Short requirements or requests written from the perspective of an end user labels Aug 23, 2021
@superkitcath superkitcath added sig/graphics-audio Categorizes an issue or PR as relevant to SIG graphics-audio. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. feature/graphics This item is related to the Atom renderer or graphics. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 23, 2021
@wintermute-motherbrain wintermute-motherbrain added good-first-issue Issue ready for a new contributor according to the help wanted guidelines. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 15, 2021
@wintermute-motherbrain
Copy link

The SIG (sig-graphics-audio) has approved this feature request and we feel it is a good first issue for the community. Additionally, we'd like to get more details on what you'd like to see from the feature. Any information would be helpful to ensure we can accurately deliver on the feature request @LB-ArturSiewniak.

@LB-ArturZieba
Copy link
Contributor Author

Thanks for the response! I've dug around the engine and checked existing components that could be related to the Ambient Lighting and I think the primary solution I've listed still seems to be the best option to me personally. Creating a new, standalone "Global Ambient Lighting" component would certainly be more visible, but adding it as a Light type option to the existing Light component seems like the more "elegant" solution - so I think that both approaches to that have some merit. As for properties that should be included, I think that including all parameters that are available by default on existing Light types would be a good starting point (Color, Intensity modes, and Intensity values corresponding to the selected Intensity mode). As I am not a lighting engineer, please of course take these suggestions with a grain of salt, but I think what I've described would cover all basic use cases for the global ambient lighting, and could be easily expanded as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/graphics This item is related to the Atom renderer or graphics. good-first-issue Issue ready for a new contributor according to the help wanted guidelines. kind/story Story: Short requirements or requests written from the perspective of an end user priority/minor Lowest priority. Work that may be scheduled sig/graphics-audio Categorizes an issue or PR as relevant to SIG graphics-audio.
Projects
Development

No branches or pull requests

3 participants