auras: Add .tooltipAnchor option #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wutname1
added a commit
to Wutname1/SUF
that referenced
this pull request
Jul 9, 2019
oUF Parity: oUF-wow/oUF#511
|
The anchoring restriction checks should have comments on them, for later reference. |
|
@ls- This fix does not seem to be working for me. It is anchoring to the buff button even when manually specifying cursor. When i add a print to self:GetParent().__owner.tooltipAnchor it returns nil. Looks like "self:GetParent().__owner" is the nameplate frame it's self and not the Auras frame. |
|
Damn, yeah, I'll PR a fix either later today or tomorrow, I'll add comments @p3lim asked for as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to 8.2 UI changes, we should avoid parenting GameTooltip to frames with anchoring restrictions, otherwise, GameTooltip will inherit said restrictions.
This PR addresses #510, but it also adds an option to adjust GameTooltip's anchor point w/o the need to using the
CreateIconoverride.