core: Fix contextual ping on suffix units #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rainrider
approved these changes
Sep 20, 2023
Meivyn
reviewed
Oct 29, 2023
|
|
||
| By default this wraps `C_Ping.GetContextualPingTypeForUnit(UnitGUID(frame.unit))`. | ||
| --]] | ||
| object:SetAttribute('ping-receiver', true) |
There was a problem hiding this comment.
Just wanted to let you know that this line is breaking frames when they're spawned in combat.
There was a problem hiding this comment.
Just to make it easier for me to test this, how did you encounter this? E.g. when did you get frames spawned during combat?
There was a problem hiding this comment.
I was on a world boss and it broke when players joined the raid. Due to the fact that SetAttribute can't be called in combat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.