Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an option/module to discover iSCSI targets from oVirt Engine RESTAPI #213

Closed
arachmani opened this issue Feb 1, 2021 · 6 comments · Fixed by #274
Closed

Provide an option/module to discover iSCSI targets from oVirt Engine RESTAPI #213

arachmani opened this issue Feb 1, 2021 · 6 comments · Fixed by #274
Assignees
Labels
enhancement New feature or request

Comments

@arachmani
Copy link
Member

We have oVirt Engine RESTAPI endpoint to discover iSCSI targets -
http://ovirt.github.io/ovirt-engine-api-model/4.4/#services/host/methods/iscsi_discover

We need the option to get this information using Ansible module by providing the host id.

@arachmani arachmani added the enhancement New feature or request label Feb 1, 2021
@mnecas
Copy link
Member

mnecas commented Feb 1, 2021

It is already implemented in the ovirt_host module.
https://docs.ansible.com/ansible/latest/collections/ovirt/ovirt/ovirt_host_module.html#parameter-iscsi

@mwperina
Copy link
Member

mwperina commented Feb 4, 2021

Asaf, are there any gaps in current ovirt_host implementation? If not, could you please close this issue?

@arachmani

@arachmani
Copy link
Member Author

Asaf, are there any gaps in current ovirt_host implementation? If not, could you please close this issue?

@arachmani

@mwperina, we use iscsi_details from REST API which contains: address, portal, port, and target, while ovirt_host gives us only iscsi_target which contains only target.
I'm checking if we can use ovirt_host_storage_info with #214

@arachmani
Copy link
Member Author

ovirt_host_storage_info doesn't help, we need the same parameters as we get from iscsi_details.

@mnecas
Copy link
Member

mnecas commented Feb 11, 2021

For this issue I created https://bugzilla.redhat.com/show_bug.cgi?id=1926819

@mnecas
Copy link
Member

mnecas commented May 14, 2021

Now there is a new resp parameter when doing discover iSCSI with ovirt_host and that is iscsi_targets_struct which contains all information around the targets and at the same time keeps parameter iscsi_targets simple list of targets for backwards compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants