/
NetworkPolicyUnit.java
270 lines (234 loc) · 11.3 KB
/
NetworkPolicyUnit.java
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
package org.ovirt.engine.core.bll.scheduling.policyunits;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Optional;
import javax.inject.Inject;
import org.apache.commons.lang.StringUtils;
import org.ovirt.engine.core.bll.ValidationResult;
import org.ovirt.engine.core.bll.network.host.VfScheduler;
import org.ovirt.engine.core.bll.scheduling.PolicyUnitImpl;
import org.ovirt.engine.core.bll.scheduling.SchedulingContext;
import org.ovirt.engine.core.bll.scheduling.SchedulingUnit;
import org.ovirt.engine.core.bll.scheduling.pending.PendingResourceManager;
import org.ovirt.engine.core.common.businessentities.Entities;
import org.ovirt.engine.core.common.businessentities.VDS;
import org.ovirt.engine.core.common.businessentities.VM;
import org.ovirt.engine.core.common.businessentities.network.Ipv4BootProtocol;
import org.ovirt.engine.core.common.businessentities.network.Ipv6BootProtocol;
import org.ovirt.engine.core.common.businessentities.network.Network;
import org.ovirt.engine.core.common.businessentities.network.VdsNetworkInterface;
import org.ovirt.engine.core.common.businessentities.network.VmNetworkInterface;
import org.ovirt.engine.core.common.config.Config;
import org.ovirt.engine.core.common.config.ConfigValues;
import org.ovirt.engine.core.common.errors.EngineMessage;
import org.ovirt.engine.core.common.scheduling.PerHostMessages;
import org.ovirt.engine.core.common.scheduling.PolicyUnit;
import org.ovirt.engine.core.common.scheduling.PolicyUnitType;
import org.ovirt.engine.core.compat.Guid;
import org.ovirt.engine.core.dao.network.InterfaceDao;
import org.ovirt.engine.core.dao.network.NetworkDao;
import org.ovirt.engine.core.dao.network.VmNetworkInterfaceDao;
import org.ovirt.engine.core.di.Injector;
import org.ovirt.engine.core.utils.NetworkUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@SchedulingUnit(
guid = "72163d1c-9468-4480-99d9-0888664eb143",
name = "Network",
description = "Filters out hosts that are missing networks required by VM NICs, or missing cluster's display network",
type = PolicyUnitType.FILTER
)
public class NetworkPolicyUnit extends PolicyUnitImpl {
private static final Logger log = LoggerFactory.getLogger(NetworkPolicyUnit.class);
@Inject
private InterfaceDao interfaceDao;
@Inject
private NetworkDao networkDao;
@Inject
private VmNetworkInterfaceDao vmNetworkInterfaceDao;
public NetworkPolicyUnit(PolicyUnit policyUnit,
PendingResourceManager pendingResourceManager) {
super(policyUnit, pendingResourceManager);
}
@Override
public List<VDS> filter(SchedulingContext context, List<VDS> hosts, VM vm, PerHostMessages messages) {
if (hosts == null || hosts.isEmpty()) {
return Collections.emptyList();
}
List<VDS> toRemoveHostList = new ArrayList<>();
List<VmNetworkInterface> vmNICs = vmNetworkInterfaceDao.getAllForVm(vm.getId());
Guid clusterId = hosts.get(0).getClusterId();
List<Network> clusterNetworks = networkDao.getAllForCluster(clusterId);
Map<String, Network> networksByName = Entities.entitiesByName(clusterNetworks);
Map<Guid, List<String>> hostNics = interfaceDao.getHostNetworksByCluster(clusterId);
Network displayNetwork = NetworkUtils.getDisplayNetwork(clusterNetworks);
Map<Guid, VdsNetworkInterface> hostDisplayNics = getDisplayNics(displayNetwork);
for (VDS host : hosts) {
ValidationResult result =
validateRequiredNetworksAvailable(host,
vm,
vmNICs,
displayNetwork,
networksByName,
hostNics.get(host.getId()),
hostDisplayNics.get(host.getId()));
if (result.isValid()) {
result = validatePassthroughVnics(vm.getId(), host, vmNICs);
}
if (!result.isValid()) {
toRemoveHostList.add(host);
messages.addMessages(host.getId(), result.getVariableReplacements());
messages.addMessages(host.getId(), result.getMessagesAsStrings());
}
}
hosts.removeAll(toRemoveHostList);
return hosts;
}
public Map<Guid, VdsNetworkInterface> getDisplayNics(Network displayNetwork) {
Map<Guid, VdsNetworkInterface> displayNics = new HashMap<>();
if (displayNetwork != null) {
List<VdsNetworkInterface> nics = interfaceDao.getVdsInterfacesByNetworkId(displayNetwork.getId());
for (VdsNetworkInterface nic : nics) {
displayNics.put(nic.getVdsId(), nic);
}
}
return displayNics;
}
/**
* Determine whether all required Networks are attached to the Host's Nics. A required Network, depending on
* ConfigValue.OnlyRequiredNetworksMandatoryForVdsSelection, is defined as: 1. false: any network that is defined on
* an Active vNic of the VM or the cluster's display network. 2. true: a Cluster-Required Network that is defined on
* an Active vNic of the VM.
* Vnic configured for 'passthrough' will skip the network existence check for the host and will be validated later by
* {@code validatePassthroughVnics(...)}
*
* @param vds
* the Host
* @param vm
* the VM
* @param hostNetworks
* the Host network names
* @param displayNic
* the interface on top the display network is configured
* @return the result of network compatibility check
*/
private ValidationResult validateRequiredNetworksAvailable(VDS vds,
VM vm,
List<VmNetworkInterface> vmNICs,
Network displayNetwork,
Map<String, Network> networksByName,
List<String> hostNetworks,
VdsNetworkInterface displayNic) {
List<String> missingIfs = new ArrayList<>();
boolean onlyRequiredNetworks =
Config.<Boolean> getValue(ConfigValues.OnlyRequiredNetworksMandatoryForVdsSelection);
for (final VmNetworkInterface vmIf : vmNICs) {
boolean found = false;
boolean skipNetworkExistenceCheckForVnicPassthrough = vmIf.isPassthrough();
if (vmIf.getNetworkName() == null) {
found = true;
} else {
for (String networkName : hostNetworks) {
if (skipNetworkExistenceCheckForVnicPassthrough
|| !networkRequiredOnVds(vmIf, networksByName, onlyRequiredNetworks)
|| StringUtils.equals(vmIf.getNetworkName(), networkName)) {
found = true;
break;
}
}
Network network = networksByName.get(vmIf.getNetworkName());
if (network.isExternal()) {
findPhysicalNetworkNotConnectedAndLinkedTo(network, hostNetworks).ifPresent(missingIfs::add);
}
}
if (!found) {
missingIfs.add(vmIf.getNetworkName());
}
}
if (!missingIfs.isEmpty()) {
String nics = StringUtils.join(missingIfs, ", ");
log.warn("host {} is missing networks required by VM nics {}",
vds.getName(), nics);
return new ValidationResult(EngineMessage.VAR__DETAIL__NETWORK_MISSING,
String.format("$networkNames %1$s", nics));
}
return validateDisplayNetworkAvailability(vds, onlyRequiredNetworks, displayNic, displayNetwork);
}
private boolean networkRequiredOnVds(VmNetworkInterface vmIface,
Map<String, Network> networksByName,
boolean onlyRequiredNetworks) {
if (!vmIface.isPlugged()) {
return false;
}
Network network = networksByName.get(vmIface.getNetworkName());
if (onlyRequiredNetworks) {
return network.getCluster().isRequired();
}
return !network.isExternal();
}
private Optional<String> findPhysicalNetworkNotConnectedAndLinkedTo(Network network, List<String> hostNetworks) {
if (!network.getProvidedBy().isSetPhysicalNetworkId()) {
return Optional.empty();
}
Network physicalNetwork = networkDao.get(network.getProvidedBy().getPhysicalNetworkId());
return Optional.ofNullable(hostNetworks.contains(physicalNetwork.getName()) ? null : physicalNetwork.getName());
}
/**
* Determines whether the cluster's display network is defined on the host.
*
* @param host
* the host
* @param onlyRequiredNetworks
* should be false, in order the method to be non-trivial.
* @param displayNic
* the interface on top the display network is configured
* @param displayNetwork
* the cluster's display network
* @return the result of the display network validity check on the given host
*/
private ValidationResult validateDisplayNetworkAvailability(VDS host,
boolean onlyRequiredNetworks,
VdsNetworkInterface displayNic,
Network displayNetwork) {
if (onlyRequiredNetworks) {
return ValidationResult.VALID;
}
if (displayNetwork == null) {
return ValidationResult.VALID;
}
// Check if display network attached to host and has a proper boot protocol
if (displayNic == null) {
log.warn("host {} is missing the cluster's display network {}",
host.getName(),
displayNetwork.getName());
return new ValidationResult(EngineMessage.VAR__DETAIL__DISPLAY_NETWORK_MISSING,
String.format("$DisplayNetwork %1$s", displayNetwork.getName()));
}
if (displayNic.getIpv4BootProtocol() == Ipv4BootProtocol.NONE
&& displayNic.getIpv6BootProtocol() == Ipv6BootProtocol.NONE) {
log.warn("Host {} has the display network {} configured with improper boot protocol on interface {}.",
host.getName(),
displayNetwork.getName(),
displayNic.getName());
return new ValidationResult(EngineMessage.VAR__DETAIL__DISPLAY_NETWORK_HAS_NO_BOOT_PROTOCOL,
String.format("$DisplayNetwork %1$s", displayNetwork.getName()));
}
return ValidationResult.VALID;
}
private ValidationResult validatePassthroughVnics(Guid vmId, VDS host,
List<VmNetworkInterface> vnics) {
VfScheduler vfScheduler = Injector.get(VfScheduler.class);
List<String> problematicVnics = vfScheduler.validatePassthroughVnics(vmId, host.getId(), vnics);
if (!problematicVnics.isEmpty()) {
String vnicsString = StringUtils.join(problematicVnics, ", ");
log.warn("host {} doesn't contain suitable virtual functions for VM nics {}",
host.getName(), vnicsString);
return new ValidationResult(EngineMessage.VAR__DETAIL__NO_SUITABLE_VF,
String.format("$vnicNames %1$s", vnicsString));
}
return ValidationResult.VALID;
}
}