Add Viaq installation guide to the oVirt metrics store repo #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sradco
changed the title
|
@richm Whould appreciate your review of my change. |
richm
reviewed
Mar 13, 2018
| ------------------------ | ||
|
|
||
| These instructions and config files are for an all-in-one, single machine, run | ||
| ansible on the same machine you are installing ViaQ on. |
There was a problem hiding this comment.
This is the same as the next paragraph. You can remove it.
richm
reviewed
Mar 26, 2018
| e.g. `chgrp 65534 /var/lib/elasticsearch` | ||
| - make this directory writable by the group `chmod -R g+w /var/lib/elasticsearch` | ||
|
|
||
| # chgrp 65534 /var/lib/elasticsearch` |
There was a problem hiding this comment.
I think you need a blank line after this line
There was a problem hiding this comment.
@sradco
I think you are missing the headers, like these for example:
title: oVirt Metrics Store - Installation Guide
category: feature
authors: sradco
feature_name: oVirt Metrics Store Installation
feature_modules: engine
feature_status: In Development
Please add them, and we will see if the CI pass
sandrobonazzola
pushed a commit
that referenced
this pull request
Jan 8, 2019
Add Viaq installation guide to the oVirt metrics store repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the viaq installation to the oVirt repo, So we can remove the steps that were already automated.
I confirm that this pull request was submitted according to the contribution guidelines: @sradco
This pull request needs review by: @mykaul