Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use modal dialog pattern instead of popover #587

Closed
gregsheremeta opened this issue May 2, 2018 · 7 comments
Closed

use modal dialog pattern instead of popover #587

gregsheremeta opened this issue May 2, 2018 · 7 comments
Labels
Flag: Redesign used to tag all 2018 redesign PRs and commits Severity: Low For bugs, lowly severe bugs. For enhancements, small scope or impact Type: Enhancement an enhancement (i.e. not a bug)

Comments

@gregsheremeta
Copy link
Contributor

Destructive operations such as shutdown and stop VM should present the user with modal confirmation dialogs. The pattern is under active design by the patternfly team, but we can see what it looks like already: patternfly/patternfly-design#632

So instead of this:
37150654-c8950d56-22d2-11e8-974e-4079247bf383

We need this:
selection_547

@gregsheremeta
Copy link
Contributor Author

cc @jelkosz @sjd78

@mareklibra
Copy link
Contributor

Thanks for reporting it. So far, we wanted to avoid modal dialogs as possible.
Anyway, time changed and if this pattern becomes part of patternfly, it makes sense to follow it.

I can imagine there will be patternfly-react implementation for this. If so, we should use it.

@bond95
Copy link
Contributor

bond95 commented May 2, 2018

@mareklibra Actually we already have confirmation modal dialog, for deleting NIC or Disks, thus dialog for shutdown button not gonna conflict with current UX.

image

@mareklibra
Copy link
Contributor

mareklibra commented May 2, 2018

Oh, right. So let's reuse it.

The point was, that patternfly suggests to use modal dialog to confirm.

@gregsheremeta
Copy link
Contributor Author

@lizsurette @jennyhaines

@gregsheremeta gregsheremeta added the Flag: Redesign used to tag all 2018 redesign PRs and commits label Jun 26, 2018
@gregsheremeta gregsheremeta modified the milestones: v1.4.0, Future release Jul 30, 2018
@gregsheremeta gregsheremeta added Type: Enhancement an enhancement (i.e. not a bug) Severity: Low For bugs, lowly severe bugs. For enhancements, small scope or impact labels Aug 1, 2018
@sjd78
Copy link
Member

sjd78 commented Aug 23, 2018

@gregsheremeta - @bond95 did this work in #654, and it was in release 1.4.2

@bond95
Copy link
Contributor

bond95 commented Aug 24, 2018

Already implemented in redesign.

@bond95 bond95 closed this as completed Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Flag: Redesign used to tag all 2018 redesign PRs and commits Severity: Low For bugs, lowly severe bugs. For enhancements, small scope or impact Type: Enhancement an enhancement (i.e. not a bug)
Projects
None yet
Development

No branches or pull requests

4 participants