New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use modal dialog pattern instead of popover #587
Comments
Thanks for reporting it. So far, we wanted to avoid modal dialogs as possible. I can imagine there will be patternfly-react implementation for this. If so, we should use it. |
@mareklibra Actually we already have confirmation modal dialog, for deleting NIC or Disks, thus dialog for shutdown button not gonna conflict with current UX. |
Oh, right. So let's reuse it. The point was, that patternfly suggests to use modal dialog to confirm. |
@gregsheremeta - @bond95 did this work in #654, and it was in release 1.4.2 |
Already implemented in redesign. |
Destructive operations such as shutdown and stop VM should present the user with modal confirmation dialogs. The pattern is under active design by the patternfly team, but we can see what it looks like already: patternfly/patternfly-design#632
So instead of this:
We need this:
The text was updated successfully, but these errors were encountered: