Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a branch/release for pre plugin-sdk release #196

Closed
rgolangh opened this issue Feb 19, 2020 · 6 comments
Closed

Create a branch/release for pre plugin-sdk release #196

rgolangh opened this issue Feb 19, 2020 · 6 comments
Labels
question Further information is requested

Comments

@rgolangh
Copy link
Contributor

This issue is release oriented.

Motivation
OKD installer [1] is vendoring the provider, along with few others and all
of them, till certain point in time[2] still don't use the terraform plugin-sdk.
Now I'm in a point where I need to fix something in the provider, and to revendor
it, but I'm blocked because our provider already migrated to the plugin-sdk [3]
Hence I need a way to consume and maintain a version which is still pre plugin sdk.

The way to do it is most probably to branch from [3] and cherry pick fixes on top.

@imjoey Since I didn't create any release on this repo yet I want hear your thoughts about how to address that.

[1] https://github.com/openshift/installer
[2] openshift/installer#2745
[3] #188

@rgolangh rgolangh added the question Further information is requested label Feb 19, 2020
@rgolangh rgolangh linked a pull request Feb 19, 2020 that will close this issue
@rgolangh rgolangh removed a link to a pull request Feb 19, 2020
@imjoey
Copy link
Member

imjoey commented Feb 19, 2020

@rgolangh , IMO, a new branch is good choice for this. While I still have two more questions:

  • Need the new branch to release a series of versions? Is that possible just use commit id for importing?
  • How long will the new (temporary) branch exist for ?

Thanks.

@rgolangh
Copy link
Contributor Author

rgolangh commented Apr 3, 2020

@rgolangh , IMO, a new branch is good choice for this. While I still have two more questions:

* Need the new branch to release a series of versions? Is that possible just use commit id for importing?

Do you mean for cherry picking?

* How long will the new (temporary) branch exist for ?

OKD 4.4 installer uses that and it only changes in 4.5. For me it should be there as long as OKD .4.4 will use it.

Thanks.

@rgolangh
Copy link
Contributor Author

rgolangh commented Apr 3, 2020

Rebase is clean and the diff shows only changes to the import statements:
git diff origin/master origin/terraform-v0.12.2 ovirt/

@rgolangh
Copy link
Contributor Author

rgolangh commented Apr 3, 2020

Also left a comment on the README to note about the terraform version
https://github.com/oVirt/terraform-provider-ovirt/tree/terraform-v012.2

@rgolangh
Copy link
Contributor Author

rgolangh commented Apr 3, 2020

@imjoey Before closing this, do you have any way to automate cherry picks? github actions? travis?

@rgolangh
Copy link
Contributor Author

rgolangh commented Apr 6, 2020

closing for now. CI is a different topic we need to handle.

@rgolangh rgolangh closed this as completed Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants