Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider updating the visuals to better match the current GNOME visuals. #185

Open
PauloVBettio opened this issue Apr 22, 2023 · 16 comments · May be fixed by #280
Open

Consider updating the visuals to better match the current GNOME visuals. #185

PauloVBettio opened this issue Apr 22, 2023 · 16 comments · May be fixed by #280
Labels
enhancement New feature or request Priority Medium Priority Medium

Comments

@PauloVBettio
Copy link

The current visual does not match the GNOME visuals and ends up being too different from other applications that use Libadwaita.

I've made a concept showing a new design that is similar to the Libadwaita apps

Pano

@PauloVBettio PauloVBettio added the enhancement New feature or request label Apr 22, 2023
@PauloVBettio
Copy link
Author

Maybe an design that is like the shell Screenshot tool would make more sense too, and it looks very nice.

I don't know if it is possible to an extension to focus on a window like the Screenshot tool from the shell does, but that would be a nice feature too.

PanoHorizontal
PanoVertical

@3laws
Copy link

3laws commented Apr 30, 2023

I honestly was already sold on the extension based on a text only description, later by coming here to GitHub to find out it didn't follow GNOME's HIG. Not a deal breaker but surely a very welcome addition. These mock ups look really good to be honest. Hopefully we can get something similar merged.

@gcalabria
Copy link

I love Pano, I use it every day and I like the way it looks now. With that said, this design looks awesome! It would be amazing if this became a reality.

@oae
Copy link
Owner

oae commented Apr 30, 2023

This looks really nice. I will experiment with Pano using these designs

@oae
Copy link
Owner

oae commented Apr 30, 2023

There is also another design by @callmehanu #170

@callmehanu
Copy link

callmehanu commented Apr 30, 2023

Yep... even I worked on a short prototype Figma Prototype @PauloVBettio @g-lopes @3laws

  • Press "Q" to show/hide Panos
  • Press "I" to start search
  • Press "ESC" to quit search

@PauloVBettio
Copy link
Author

PauloVBettio commented Apr 30, 2023

Yep... even I worked on a short prototype Figma Prototype @PauloVBettio @g-lopes @3laws

* Press "Q" to launch Panos

* Press "I" to start search

* Press "ESC" to quit search

The animations are sweet! And it fits the shell very well too. Awesome work!
I just think there should be a search button always visible, since its not everyone who will check the settings to see which one it is. And the square cards in your example are better than the rectangular ones in mine, because more elements can fit in the screen.

@marcinjahn
Copy link

I just think there should be a search button always visible, since its not everyone who will check the settings to see which one it is

Ideally, it should be configurable, IMO, searchbar should appear only as soon as you start typing.

@boerdereinar
Copy link

boerdereinar commented Apr 24, 2024

For anyone interested, I made my own fork roughly following the concept.

image

@oae
Copy link
Owner

oae commented Apr 24, 2024

This looks good. It would be awesome to apply this design while keeping the customization features. What do you think @Totto16 ?

@Totto16
Copy link
Collaborator

Totto16 commented Apr 24, 2024

This looks good. It would be awesome to apply this design while keeping the customization features. What do you think @Totto16 ?

I like the proposed new design too, but the old (current) is also nice. To be fair they differ a lot, this looks more sleek, with more focus on the actual content and no "big" header.

"You can never have enough customization options" is also a good point, although we already have many options, it is also possible in my opinion, to add another option to have the new look, alltough that might not be worth the trouble and resulting "spaghetti code" 😂

What speaks against immediately adopting this is, that all tough the current style is older, it's also better in terms of functionality IMO, since you can immediately see the big header, and immediately see the type.

The round styles and headerless design is really good per sè, but we would need to improve a few points and merge the good suggestion in this issue to get a good version.

All in all I find the new one good, but the old one too, and I am torn apart, which is better imo, but in the long run the newer, sleeker one is better.

Some suggestions from this thread are also nice, like the floating option, (that was also requested in #124) is a good idea.

TLDR: 🤷🏼‍♂️ 😓

@marcinjahn
Copy link

marcinjahn commented Apr 24, 2024

I can only imagine how terrible it must be to introduce any new features at the moment, with the amount of customization that the extension allows, and potential places where things can break. I think it’d be best to switch to a style resembling libadwaita, and remove appearance customization options, or leave only some basic ones. Maintenance of the project should become much easier then

@Totto16
Copy link
Collaborator

Totto16 commented Apr 24, 2024

Customizations aren't terrible to maintain and don't break easy, e.g. setting the color means that we retrieve the color from a setting instead of hard-coding it, that's't not difficult and error prone.

But the entire style, like header, widgets etc. is a little more complicated, thats error-prone and harder to maintain for future gnome versions

@boerdereinar
Copy link

boerdereinar commented Apr 28, 2024

Made a second version:

  • All customisation options that are still relevant, work
  • Added Compact Mode that is useful in vertical mode
  • Added option to only show controls on hover
  • Files item now shows the number of files that were copied/cut
  • Files item now renders as a tree branching from the top level directory. This makes it so that individual file names can actually be read
  • Color item now follows the prototype design and picks the font color automatically so that it should stay legible for any color

Next thing I will probably be trying when I have time again will be to reimplement the headers.

https://github.com/boerdereinar/gnome-shell-pano/tree/gnome-theming-v2

Controls only on hover:
image

Compact Mode:
image

Customisation:
image

@SoMuchForSubtlety
Copy link

I would consider getting in touch with the gnome design team to get feedback on the design.

@boerdereinar
Copy link

Headers can now be enabled again.

image

@boerdereinar boerdereinar linked a pull request May 8, 2024 that will close this issue
9 tasks
@Totto16 Totto16 added the Priority Medium Priority Medium label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority Medium Priority Medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants