Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node 0.10 #415

Closed
nicolaasmatthijs opened this issue Mar 12, 2013 · 10 comments
Closed

Upgrade to Node 0.10 #415

nicolaasmatthijs opened this issue Mar 12, 2013 · 10 comments
Assignees

Comments

@nicolaasmatthijs
Copy link
Contributor

http://joyent.com/blog/announcing-the-latest-node-update

Also run a performance test as part of this to make sure that it doesn't slow things down.

@simong
Copy link
Contributor

simong commented Mar 18, 2013

Might want to hold off on that till nodejs/node-v0.x-archive#5015 (comment) has been resolved.

@nicolaasmatthijs
Copy link
Contributor Author

It looks like 0.10.1 has a partial solution, but the final solution won't be there until 0.10.2

@mrvisser
Copy link
Contributor

We should hold off until 0.10.2.

The newest joyent base images ship with node 0.10.1 ATM. Our provisioning scripts now uninstall the bundled nodejs package, and then the puppet scripts will install 0.8.22.

The act of "upgrading to 0.10" should just be a matter of bumping up the nodejs version installed in the hilary module of the puppet-hilary production branch (as well as README.md fixes where needed) and testing the provisioning process.

@nicolaasmatthijs
Copy link
Contributor Author

Assigning to Branden, but putting on hold.

@ghost ghost assigned mrvisser Apr 24, 2013
@stuartf
Copy link
Contributor

stuartf commented Jun 4, 2013

0.10.6 is available now, should this be marked as to fix

@nicolaasmatthijs
Copy link
Contributor Author

Setting to To Fix, but keeping out of R1. This needs performance testing + some investigation on whether or not we can more efficiently use the streaming API.

@nicolaasmatthijs
Copy link
Contributor Author

@mrvisser : Are there any outstanding tasks before this can be resolved?

@mrvisser
Copy link
Contributor

We can move forward on it now that we've validated the crypto stuff no longer causes a severe degradation. We should:

  • Run in QA and sanity check things like PP and Etherpad which don't get good coverage in performance tests. A 30min bug bash should do
  • Look at the streaming API changes as mentioned to see if we're using any soon-to-be-deprecated stuff and switch those around

@simong
Copy link
Contributor

simong commented Aug 23, 2013

node 0.10 is now running on release0 and has been merged into puppet-hilary@master. Can this be closed?

@mrvisser
Copy link
Contributor

Upgraded in release and in production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants