Skip to content
This repository has been archived by the owner on Aug 28, 2023. It is now read-only.

[Question] 'controllerDir' and 'x-oai-controller' name choice. #25

Closed
rlataguerra opened this issue May 3, 2017 · 2 comments
Closed

Comments

@rlataguerra
Copy link

Hi,

First, I wanted to say that your router is really great !

But I have a question about x-oai-controller and controllerDir names.
Why didnt you name them "x-oai-middleware" and "middlewareDir" ?

@amazing-gao
Copy link
Collaborator

Thanks for your advice.
I design it as a MVC framework router, so i name it controller in the very beginning.
While your advice makes me realize that koa middleware is better.
In the next version, I will add alias middlewareDir and x-oai-middleware . And the old two terms will be observed in terms of compatibility.

@rlataguerra
Copy link
Author

great !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants