Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle mode shortcut (ctrl-shift-9) is colliding with Atom Git integration #95

Open
tad-lispy opened this issue Nov 1, 2017 · 1 comment
Assignees

Comments

@tad-lispy
Copy link

Parinfer is awesome. Thank you.

In recent versions of Atom there is a GitHub integration package (https://github.com/blog/2362-announcing-git-integration-for-atom-and-github-desktop-beta) shipped with the editor. It uses ctrl-shift-9 shortcut (which is the same as ctrl-( on most keyboards) to toggle Git pane. Personally I use it a lot. After installing Parinfer, the GitHub shortcut stopped working, as it is masked by the Toggle Mode shortcut.

Obviously I can remap one of them, but since GitHub integration is a core package, perhaps a different default shortcut should be considered for Parinfer.

@oakmac
Copy link
Owner

oakmac commented Nov 2, 2017

Thank you for bringing this up.

It's a bummer there is a conflict with a core package. I like the "( to activate / toggle modes", ") to disable" shortcuts. I always thought they were fitting for a Lisp-focused extension.

I need to give this a think about what to do. I believe Parinfer extensions in other editors (specifically Sublime Text and VS Code) use the same shortcuts too.

@oakmac oakmac self-assigned this Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants