Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shaping Outline should use width/height deltas to determine starting point #5

Closed
200sc opened this issue Jul 17, 2017 · 1 comment
Closed

Shaping Outline should use width/height deltas to determine starting point #5

200sc opened this issue Jul 17, 2017 · 1 comment
Labels
bug
Milestone
1.2

Comments

@200sc
Copy link
Contributor

200sc commented Jul 17, 2017

Right now ToOutline in shape will use a straight 45 degree line to find a starting point for a shape's outline:

x . . . .
. x . . .
. . x . .
. . . x .
. . . . x

But this will fail for particularly wide or tall shapes. The diagonal used should be dependent on the width and height of the given shape to be successful on more input shapes.
@200sc 200sc added the bug label Jul 17, 2017
@200sc 200sc added this to the 1.1 milestone Jul 19, 2017
@200sc
Copy link
Contributor Author

200sc commented Jul 31, 2017

This is ready as of 41057e5

@200sc 200sc mentioned this issue Aug 4, 2017
Merged
@200sc 200sc closed this as completed Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.2
Development

No branches or pull requests
1 participant
@200sc