Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/open-this.t fails with perl 5.37.x #48

Closed
eserte opened this issue May 1, 2023 · 1 comment · Fixed by #49
Closed

t/open-this.t fails with perl 5.37.x #48

eserte opened this issue May 1, 2023 · 1 comment · Fixed by #49

Comments

@eserte
Copy link

eserte commented May 1, 2023

I see the following test failure with recent bleadperls (maybe related to changed serialization of booleans):

#   Failed test 'line 3'
#   at t/open-this.t line 167.
# +----+------------------------------------------------+------------------------------------------------+
# | Elt|Got                                             |Expected                                        |
# +----+------------------------------------------------+------------------------------------------------+
# |   0|{                                               |{                                               |
# |   1|  file_name => 't/lib/Foo/Bar.pm',              |  file_name => 't/lib/Foo/Bar.pm',              |
# *   2|  is_module_name => !!1,                        |  is_module_name => 1,                          *
# |   3|  line_number => 3,                             |  line_number => 3,                             |
# |   4|  original_text => 'Foo::Bar::do_something()',  |  original_text => 'Foo::Bar::do_something()',  |
# |   5|  sub_name => 'do_something'                    |  sub_name => 'do_something'                    |
# |   6|}                                               |}                                               |
# +----+------------------------------------------------+------------------------------------------------+
# Looks like you failed 1 test of 59.
t/open-this.t .......... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/59 subtests 
oalders added a commit that referenced this issue May 4, 2023
oalders added a commit that referenced this issue May 4, 2023
@oalders
Copy link
Member

oalders commented May 4, 2023

Thanks for this, @eserte! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants