Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kate editor #17

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Conversation

jjatria
Copy link
Contributor

@jjatria jjatria commented Jun 12, 2019

This patch adds support for Kate, the default text editor in KDE.

This is a bit different to the existing editors, since unlike the rest, this is a graphical editor (not one that runs in the terminal). Still, when a window is already open, running kate filename will open that file in the existing window, so a utility like ot can be very useful (it certainly has been for me).

The one thing that could be improved is that, if no window is open, ot will create a new one, but will not detach from it, which can be a bit annoying (sadly, Kate does not seem to have an option to avoid this, so it needs to be done with invocations like kate foo &, which I'm not sure if we can use in this case).

Anyway, let me know what you think!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 110

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 98.347%

Totals Coverage Status
Change from base Build 109: 0.06%
Covered Lines: 119
Relevant Lines: 121

💛 - Coveralls

@oalders
Copy link
Member

oalders commented Jun 13, 2019

@jjatria thanks. This looks great. I was going to ask you to add kate to the docs but after having a look I realized that I haven't clearly documented the already supported editors, so I'll do that before I release this. :)

Not sure what to do about detaching, but let's start with this and see how it goes.

@oalders oalders merged commit 6c7c847 into perl-ide:master Jun 13, 2019
@jjatria
Copy link
Contributor Author

jjatria commented Jun 13, 2019

Thanks for merging this so quickly! 🎉

I agree that thinking about detaching can come later, if at all.

@jjatria jjatria deleted the kate-editor branch June 13, 2019 19:59
@oalders
Copy link
Member

oalders commented Jun 14, 2019

A new version is now on its way to CPAN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants