Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Trait] Add an example of CronHPA Trait #44

Merged
merged 1 commit into from
Jul 14, 2020
Merged

[Trait] Add an example of CronHPA Trait #44

merged 1 commit into from
Jul 14, 2020

Conversation

majian159
Copy link
Contributor

@majian159 majian159 commented Jul 14, 2020 •
edited
Loading

Description of your changes
Add CronHPA Trait
Add CronHPA Trait example yamls and README

How has this code been tested?
Refer toREADME

Checklist

I have:

  • Title of the PR starts with OAM type (e.g. [Workload] or [Trait] or [Scope]).
  • Updated/Added any relevant [documentation] and [examples].
  • Unit/E2E Tests added.

@ghost
Copy link

ghost commented Jul 14, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

wonderflow
wonderflow approved these changes Jul 14, 2020
View reviewed changes
Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your work

@wonderflow wonderflow merged commit 9a64346 into kubevela:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonderflow wonderflow wonderflow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@majian159 @wonderflow