Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move template out from extension to spec.template #1014

Merged
merged 1 commit into from Feb 5, 2021

Conversation

wonderflow
Copy link
Collaborator

@wonderflow wonderflow commented Feb 4, 2021

fix #976

I still keep the compatibility for extension.template, so the existing definition file won't fail.

@wonderflow wonderflow marked this pull request as draft February 4, 2021 14:11
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #1014 (34ae24c) into master (b6f10bb) will decrease coverage by 0.03%.
The diff coverage is 26.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1014      +/-   ##
==========================================
- Coverage   38.33%   38.30%   -0.04%     
==========================================
  Files         114      114              
  Lines        9556     9574      +18     
==========================================
+ Hits         3663     3667       +4     
- Misses       5422     5430       +8     
- Partials      471      477       +6     
Flag Coverage Δ
unittests 38.30% <26.98%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/appfile/parser.go 68.27% <0.00%> (ø)
pkg/commands/refresh.go 15.23% <ø> (ø)
...tiondeployment/applicationdeployment_controller.go 0.00% <0.00%> (ø)
pkg/plugins/capcenter.go 20.33% <0.00%> (ø)
pkg/oam/util/template.go 37.50% <31.81%> (+14.09%) ⬆️
pkg/plugins/cluster.go 47.26% <46.15%> (-1.72%) ⬇️
...dev/v1alpha2/traitdefinition/validating_handler.go 54.05% <66.66%> (-3.45%) ⬇️
cmd/core/main.go 20.25% <100.00%> (+0.50%) ⬆️
pkg/utils/apply/apply.go 95.74% <100.00%> (ø)
...andard.oam.dev/v1alpha1/routes/route_controller.go 65.47% <0.00%> (-4.17%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6f10bb...96a589b. Read the comment docs.

@wonderflow wonderflow changed the title move template out from extension move template out from extension to spec.template Feb 5, 2021
Copy link
Collaborator

@zzxwill zzxwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wonderflow wonderflow merged commit 4b06961 into kubevela:master Feb 5, 2021
@wonderflow wonderflow deleted the definition branch February 5, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade template out from extension of Definition Spec
2 participants