Add a new cloneset scale controller #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanzhang-oss
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1301 +/- ##
==========================================
- Coverage 54.77% 51.37% -3.40%
==========================================
Files 76 81 +5
Lines 7305 7922 +617
==========================================
+ Hits 4001 4070 +69
- Misses 2819 3366 +547
- Partials 485 486 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ryanzhang-oss
force-pushed
the
add-cloneset-scale
branch
2 times, most recently
from
85a8d83
to
fa07f19
Compare
ryanzhang-oss
force-pushed
the
add-cloneset-scale
branch
from
fa07f19
to
981ce41
Compare
ryanzhang-oss
force-pushed
the
add-cloneset-scale
branch
from
28371af
to
fb84f6a
Compare
ryanzhang-oss
force-pushed
the
add-cloneset-scale
branch
from
1f5eb34
to
f3d7662
Compare
ryanzhang-oss
changed the title
wonderflow
reviewed
Apr 7, 2021
| @@ -141,7 +139,7 @@ func TestMakeHTTPRequest(t *testing.T) { | |||
| if string(gotReply) != tt.want.body { | |||
| t.Errorf("\n%s\nr.Reconcile(...): want reply `%s`, got reply:`%s`\n", testName, tt.want.body, string(gotReply)) | |||
| } | |||
| }) | |||
| }(testName) | |||
There was a problem hiding this comment.
the test will run serial not pararell now.
wonderflow
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new cloneset scale controller