-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package discover refresh when component/trait definition are registered #1402
Conversation
64c8e16
to
9830b22
Compare
609a1f1
to
c69faf2
Compare
Codecov Report
@@ Coverage Diff @@
## master #1402 +/- ##
==========================================
- Coverage 51.50% 51.46% -0.04%
==========================================
Files 81 81
Lines 8013 8077 +64
==========================================
+ Hits 4127 4157 +30
- Misses 3386 3418 +32
- Partials 500 502 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
3c77a4d
to
7c5917a
Compare
0f90b7f
to
290a956
Compare
f003220
to
f754189
Compare
pkg/controller/core.oam.dev/v1alpha2/core/traits/traitdefinition/testdata/example.go
Outdated
Show resolved
Hide resolved
pkg/controller/core.oam.dev/v1alpha2/core/traits/traitdefinition/traitdefinition_suite_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix #1387
refresh package discover when component/trait definition are registered.