Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package discover refresh when component/trait definition are registered #1402

Merged
merged 4 commits into from
Apr 8, 2021

Conversation

yangsoon
Copy link
Collaborator

@yangsoon yangsoon commented Apr 1, 2021

fix #1387

refresh package discover when component/trait definition are registered.

  • add discover refresh
  • add test

@yangsoon yangsoon force-pushed the fix-controller branch 5 times, most recently from 64c8e16 to 9830b22 Compare April 1, 2021 09:56
pkg/oam/util/helper.go Outdated Show resolved Hide resolved
@yangsoon yangsoon force-pushed the fix-controller branch 9 times, most recently from 609a1f1 to c69faf2 Compare April 4, 2021 13:12
@codecov
Copy link

codecov bot commented Apr 4, 2021

Codecov Report

Merging #1402 (f86a9e3) into master (a44257e) will decrease coverage by 0.03%.
The diff coverage is 48.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1402      +/-   ##
==========================================
- Coverage   51.50%   51.46%   -0.04%     
==========================================
  Files          81       81              
  Lines        8013     8077      +64     
==========================================
+ Hits         4127     4157      +30     
- Misses       3386     3418      +32     
- Partials      500      502       +2     
Flag Coverage Δ
unittests 51.46% <48.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/utils/utils.go 22.50% <0.00%> (-5.93%) ⬇️
pkg/oam/util/helper.go 67.19% <ø> (ø)
pkg/controller/utils/capability.go 45.85% <44.00%> (-1.27%) ⬇️
...ponentdefinition/componentdefinition_controller.go 84.37% <100.00%> (+2.23%) ⬆️
...aits/traitdefinition/traitdefinition_controller.go 81.39% <100.00%> (+15.68%) ⬆️
pkg/oam/discoverymapper/mapper.go 66.66% <100.00%> (+4.16%) ⬆️
...ha2/core/components/componentdefinition/handler.go 72.72% <0.00%> (-6.07%) ⬇️
...v1alpha2/appdeployment/appdeployment_controller.go 50.98% <0.00%> (-0.20%) ⬇️
pkg/dsl/model/sets/utils.go 76.05% <0.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a44257e...f86a9e3. Read the comment docs.

@yangsoon yangsoon force-pushed the fix-controller branch 8 times, most recently from 3c77a4d to 7c5917a Compare April 5, 2021 04:33
@yangsoon yangsoon changed the title [WIP] Add package discover refresh when component/trait definition are registered Add package discover refresh when component/trait definition are registered Apr 5, 2021
@yangsoon yangsoon changed the title Add package discover refresh when component/trait definition are registered [WIP]Add package discover refresh when component/trait definition are registered Apr 5, 2021
@yangsoon yangsoon force-pushed the fix-controller branch 2 times, most recently from 0f90b7f to 290a956 Compare April 6, 2021 01:34
@yangsoon yangsoon changed the title [WIP]Add package discover refresh when component/trait definition are registered Add package discover refresh when component/trait definition are registered Apr 6, 2021
@yangsoon yangsoon force-pushed the fix-controller branch 2 times, most recently from f003220 to f754189 Compare April 6, 2021 02:54
Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wonderflow wonderflow merged commit 08a1dc5 into kubevela:master Apr 8, 2021
@wonderflow wonderflow deleted the fix-controller branch April 8, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support package discover refresh in trait/component definition registration
2 participants