Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add short name for crds #1434

Merged
merged 2 commits into from
Apr 8, 2021
Merged

Add short name for crds #1434

merged 2 commits into from
Apr 8, 2021

Conversation

chengshiwen
Copy link
Contributor

@chengshiwen chengshiwen commented Apr 8, 2021 •
edited

Add short name for crds as follows
image

@ghost
Copy link

ghost commented Apr 8, 2021 •
edited by ghost

CLA assistant check
All CLA requirements met.

@codecov
Copy link

codecov bot commented Apr 8, 2021 •
edited

Codecov Report

Merging #1434 (8c87e90) into master (473164e) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 8c87e90 differs from pull request most recent head 7d31d84. Consider uploading reports for the commit 7d31d84 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1434      +/-   ##
==========================================
+ Coverage   51.50%   51.51%   +0.01%     
==========================================
  Files          81       81              
  Lines        8013     8017       +4     
==========================================
+ Hits         4127     4130       +3     
- Misses       3386     3387       +1     
  Partials      500      500
Flag Coverage Δ
unittests 51.51% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...v1alpha2/appdeployment/appdeployment_controller.go 50.98% <0.00%> (-0.20%) ⬇️
pkg/dsl/model/sets/utils.go 76.05% <0.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 473164e...7d31d84. Read the comment docs.

wonderflow
wonderflow requested changes Apr 8, 2021
View reviewed changes
Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions

apis/core.oam.dev/v1alpha2/applicationcontext_types.go Outdated Show resolved Hide resolved
apis/core.oam.dev/v1alpha2/applicationrevision_types.go Outdated Show resolved Hide resolved
apis/core.oam.dev/v1beta1/appdeployment_types.go Outdated Show resolved Hide resolved
apis/core.oam.dev/v1beta1/applicationrevision_types.go Outdated Show resolved Hide resolved
apis/standard.oam.dev/v1alpha1/rollouttrait_types.go Outdated Show resolved Hide resolved
@chengshiwen chengshiwen force-pushed the add-short-name branch 2 times, most recently from f84b349 to 46b32a5 Compare April 8, 2021 11:05
wonderflow
wonderflow reviewed Apr 8, 2021
View reviewed changes
Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some research, that short name conflicts with other CRD can cause confusion and bugs, so we should only add necessary ones.

apis/core.oam.dev/v1alpha2/application_types.go Outdated Show resolved Hide resolved
apis/core.oam.dev/v1alpha2/core_scope_types.go Outdated Show resolved Hide resolved
apis/core.oam.dev/v1alpha2/componentdefinition_types.go Outdated Show resolved Hide resolved
apis/core.oam.dev/v1alpha2/core_trait_types.go Outdated Show resolved Hide resolved
apis/core.oam.dev/v1alpha2/core_types.go Outdated Show resolved Hide resolved
apis/core.oam.dev/v1alpha2/core_types.go Outdated Show resolved Hide resolved
apis/core.oam.dev/v1alpha2/core_types.go Outdated Show resolved Hide resolved
apis/core.oam.dev/v1alpha2/core_workload_types.go Outdated Show resolved Hide resolved
apis/standard.oam.dev/v1alpha1/podspecworkload_types.go Outdated Show resolved Hide resolved
wonderflow
wonderflow approved these changes Apr 8, 2021
View reviewed changes
Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@chengshiwen
Copy link
Contributor Author

The latest short names are as follows:
image

@wonderflow wonderflow merged commit d2a4632 into kubevela:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonderflow wonderflow wonderflow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chengshiwen @wonderflow