Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement-1457] Use kind cmd code to load docker image instead of local kind binary #1458

Merged
merged 2 commits into from Apr 11, 2021

Conversation

chengshiwen
Copy link
Contributor

@chengshiwen chengshiwen commented Apr 11, 2021

Just use

err := kind.LoadDockerImage(image)

instead of

cmd := exec.Command("kind", "load", "docker-image", image)

Refer to https://github.com/kubernetes-sigs/kind/blob/main/pkg/cmd/kind/load/docker-image/docker-image.go

This closes #413 and closes #1457

The docker command will be resolved after kind

@codecov
Copy link

codecov bot commented Apr 11, 2021

Codecov Report

Merging #1458 (d991b28) into master (9bf6cc2) will decrease coverage by 0.41%.
The diff coverage is 27.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1458      +/-   ##
==========================================
- Coverage   53.62%   53.21%   -0.42%     
==========================================
  Files          81       83       +2     
  Lines        8080     8180     +100     
==========================================
+ Hits         4333     4353      +20     
- Misses       3223     3307      +84     
+ Partials      524      520       -4     
Flag Coverage Δ
unittests 53.21% <27.69%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/builtin/build/build.go 14.47% <0.00%> (+2.11%) ⬆️
pkg/builtin/kind/client.go 28.57% <28.57%> (ø)
pkg/appfile/parser.go 57.69% <0.00%> (-11.00%) ⬇️
pkg/oam/util/test_utils.go 52.45% <0.00%> (-9.84%) ⬇️
...n/rollout/workloads/cloneset_rollout_controller.go 63.22% <0.00%> (-2.11%) ⬇️
pkg/dsl/definition/template.go 27.57% <0.00%> (-1.60%) ⬇️
pkg/dsl/model/instance.go 70.27% <0.00%> (-1.53%) ⬇️
pkg/webhook/common/rollout/rollout_plan.go 36.84% <0.00%> (-1.34%) ⬇️
pkg/controller/utils/capability.go 44.55% <0.00%> (-0.55%) ⬇️
pkg/dsl/definition/package.go 85.26% <0.00%> (-0.46%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bf6cc2...d991b28. Read the comment docs.

Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!

@wonderflow wonderflow merged commit 2b07ec4 into kubevela:master Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants