Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trait-injector from controller options #1490

Merged
merged 1 commit into from Apr 14, 2021

Conversation

zzxwill
Copy link
Collaborator

@zzxwill zzxwill commented Apr 14, 2021

As trait injector isn't used, so removed it.

As trait injector isn't used, so removed it.
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #1490 (e7d0246) into master (a7bfb2f) will increase coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1490      +/-   ##
==========================================
+ Coverage   55.32%   55.40%   +0.07%     
==========================================
  Files          85       85              
  Lines        8267     8254      -13     
==========================================
- Hits         4574     4573       -1     
+ Misses       3162     3150      -12     
  Partials      531      531              
Flag Coverage Δ
unittests 55.40% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/core/main.go 13.69% <0.00%> (+0.91%) ⬆️
pkg/utils/common/common.go 56.25% <ø> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7bfb2f...e7d0246. Read the comment docs.

Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wonderflow wonderflow merged commit 384c5ab into kubevela:master Apr 14, 2021
@zzxwill zzxwill deleted the remove-trait-injector branch April 14, 2021 12:01
chivalryq pushed a commit to chivalryq/kubevela that referenced this pull request Apr 22, 2021
As trait injector isn't used, so removed it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants