Enable Dynamic Admission Control for Application #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1619 +/- ##
==========================================
+ Coverage 62.00% 62.26% +0.25%
==========================================
Files 120 120
Lines 11899 11900 +1
==========================================
+ Hits 7378 7409 +31
+ Misses 3761 3725 -36
- Partials 760 766 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
zzxwill
reviewed
May 8, 2021
| if allErrs := h.ValidateUpdate(ctx, app, oldApp); len(allErrs) > 0 { | ||
| return admission.Errored(http.StatusUnprocessableEntity, allErrs.ToAggregate()) | ||
| if app.ObjectMeta.DeletionTimestamp.IsZero() { | ||
| if allErrs := h.ValidateUpdate(ctx, app, oldApp); len(allErrs) > 0 { |
There was a problem hiding this comment.
Suggested change
| if allErrs := h.ValidateUpdate(ctx, app, oldApp); len(allErrs) > 0 { | |
| if len(h.ValidateUpdate(ctx, app, oldApp)) > 0 { |
Better? :)
There was a problem hiding this comment.
This cannot be modified here, because the following logic needs to return the error in allErrs
zzxwill
reviewed
May 8, 2021
| @@ -98,5 +99,5 @@ func (h *ValidatingHandler) Handle(ctx context.Context, req admission.Request) a | |||
| // RegisterValidatingHandler will register application validate handler to the webhook | |||
| func RegisterValidatingHandler(mgr manager.Manager, args controller.Args) { | |||
| server := mgr.GetWebhookServer() | |||
| server.Register("/validating-core-oam-dev-v1alpha2-applications", &webhook.Admission{Handler: &ValidatingHandler{dm: args.DiscoveryMapper, pd: args.PackageDiscover}}) | |||
| server.Register("/validating-core-oam-dev-v1beta1-applications", &webhook.Admission{Handler: &ValidatingHandler{dm: args.DiscoveryMapper, pd: args.PackageDiscover}}) | |||
There was a problem hiding this comment.
What will happed if there the old webhook is already registered and running in a cluster?
There was a problem hiding this comment.
In fact, vela has never enable the Admission Control for Application
yangsoon
added a commit
to yangsoon/kubevela
that referenced
this pull request
May 13, 2021
* add webhook * fix test * fix validating_handler
yangsoon
added a commit
to yangsoon/kubevela
that referenced
this pull request
May 17, 2021
* add webhook * fix test * fix validating_handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable dynamic admission control for Application, the admissionWebhooks will check the correctness of the fields in Application.