fix empty rolloutBatch will panic whole controller bug #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neat imports
Codecov Report
@@ Coverage Diff @@
## master #1646 +/- ##
==========================================
- Coverage 62.39% 62.36% -0.04%
==========================================
Files 120 120
Lines 11931 11937 +6
==========================================
Hits 7444 7444
- Misses 3724 3730 +6
Partials 763 763
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
wangyikewxgm
changed the title
yangsoon
pushed a commit
to yangsoon/kubevela
that referenced
this pull request
May 13, 2021
* add webhook for app and avoid controller panic neat imports * add test for rollout verify
yangsoon
pushed a commit
to yangsoon/kubevela
that referenced
this pull request
May 17, 2021
* add webhook for app and avoid controller panic neat imports * add test for rollout verify # Conflicts: # pkg/webhook/core.oam.dev/v1alpha2/application/validating_handler_test.go # pkg/webhook/core.oam.dev/v1alpha2/application/validation.go # test/e2e-test/application_test.go
yangsoon
pushed a commit
to yangsoon/kubevela
that referenced
this pull request
May 17, 2021
* add webhook for app and avoid controller panic neat imports * add test for rollout verify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1631
1.add validation webhook to verify
rolloutBatchesmust not be empty2.guarantee empty
rolloutBatchescouldn't crash whole controller even though disable webhook