Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix addRevisionLabel to selector #1983

Merged

Conversation

tossmilestone
Copy link
Contributor

@tossmilestone tossmilestone commented Jul 29, 2021

Fix #1981

Signed-off-by: Xiaoxi He tossmilestone@gmail.com

@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #1983 (7d9e692) into master (4481e76) will decrease coverage by 2.69%.
The diff coverage is n/a.

❗ Current head 7d9e692 differs from pull request most recent head e3b2f38. Consider uploading reports for the commit e3b2f38 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1983      +/-   ##
==========================================
- Coverage   63.78%   61.08%   -2.70%     
==========================================
  Files         152      152              
  Lines       14512    14512              
==========================================
- Hits         9256     8865     -391     
- Misses       4336     4708     +372     
- Partials      920      939      +19     
Flag Coverage Δ
e2e-rollout-tests ?
e2etests 37.23% <ø> (-0.08%) ⬇️
unittests 59.04% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ard.oam.dev/v1alpha1/rollout/rollout_controller.go 24.75% <0.00%> (-55.45%) ⬇️
...dev/v1alpha2/applicationrollout/rollout_handler.go 23.68% <0.00%> (-27.64%) ⬇️
apis/standard.oam.dev/v1alpha1/rollout_state.go 44.55% <0.00%> (-26.95%) ⬇️
...ntroller/common/rollout/rollout_plan_controller.go 36.31% <0.00%> (-26.26%) ⬇️
...pplicationrollout/applicationrollout_controller.go 59.44% <0.00%> (-23.78%) ⬇️
...troller/core.oam.dev/v1alpha2/application/apply.go 62.02% <0.00%> (-19.63%) ⬇️
....oam.dev/v1alpha2/applicationrollout/validation.go 35.63% <0.00%> (-19.55%) ⬇️
.../v1alpha2/applicationrollout/validating_handler.go 50.00% <0.00%> (-17.86%) ⬇️
...core.oam.dev/v1alpha2/applicationrollout/helper.go 69.33% <0.00%> (-14.67%) ⬇️
...oller/standard.oam.dev/v1alpha1/rollout/handler.go 55.10% <0.00%> (-10.21%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4481e76...e3b2f38. Read the comment docs.

Signed-off-by: Xiaoxi He <tossmilestone@gmail.com>
@tossmilestone tossmilestone force-pushed the fix-addrevisionlabel-to-selector branch from 7d9e692 to e3b2f38 Compare July 31, 2021 08:57
Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks

@wonderflow wonderflow merged commit d9cd048 into kubevela:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The deployment of webservice will be updated failed with addRevisionLabel: true
2 participants