New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rollout controller find sourceRevision #1989
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1989 +/- ##
==========================================
+ Coverage 59.09% 64.04% +4.95%
==========================================
Files 111 159 +48
Lines 10998 14973 +3975
==========================================
+ Hits 6499 9590 +3091
- Misses 3804 4419 +615
- Partials 695 964 +269
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
test/e2e-test/testdata/rollout/deployment/rolloutDefinition.yaml
Outdated
Show resolved
Hide resolved
test/e2e-test/testdata/rollout/deployment/webServiceDefinition.yaml
Outdated
Show resolved
Hide resolved
modify docs example modify cue and yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
application use rollout as a trait, user shouldn't care sourceRevision.
when a new rollout restart, rollout controller use
status.LastTtargetRevision
as sourceRevisionapplication using rollout trait example is:
Which issue(s) this PR fixes:
related issue: #1605
Special notes for your reviewer: