suppress dirty logs during import libraries #1991
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The vela CLI tools prints "getCPUInfo" error for
darwin/arm64
architecture which confuses Mac M1 users. Besides, the "throttling request" message logged during the import process is not necessary for the CLI tool. This PR suppress these two loggings during the init stage. The logging is recovered when the import process is over and the CLI starts to execute.Which issue(s) this PR fixes:
Fixes #1924
Special notes for your reviewer:
The solution is to suppress loggings from
containerd
lib for "getCPUInfo" log andklog
for "throttling request" in client-go. Theklog
logging is brought back when the CLI command starts execution.