Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress dirty logs during import libraries #1991

Merged
merged 1 commit into from Jul 30, 2021

Conversation

Somefive
Copy link
Collaborator

What this PR does / why we need it:

The vela CLI tools prints "getCPUInfo" error for darwin/arm64 architecture which confuses Mac M1 users. Besides, the "throttling request" message logged during the import process is not necessary for the CLI tool. This PR suppress these two loggings during the init stage. The logging is recovered when the import process is over and the CLI starts to execute.

Which issue(s) this PR fixes:

Fixes #1924

Special notes for your reviewer:

The solution is to suppress loggings from containerd lib for "getCPUInfo" log and klog for "throttling request" in client-go. The klog logging is brought back when the CLI command starts execution.

@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #1991 (8a7091e) into master (7161959) will increase coverage by 4.72%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1991      +/-   ##
==========================================
+ Coverage   59.09%   63.81%   +4.72%     
==========================================
  Files         111      158      +47     
  Lines       10998    14892    +3894     
==========================================
+ Hits         6499     9504    +3005     
- Misses       3804     4422     +618     
- Partials      695      966     +271     
Flag Coverage Δ
e2e-rollout-tests 28.82% <ø> (?)
e2etests 38.11% <ø> (?)
unittests 59.13% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...core.oam.dev/v1alpha2/componentdefinition_types.go 0.00% <0.00%> (ø)
apis/core.oam.dev/v1alpha2/core_types.go 0.00% <0.00%> (ø)
...m.dev/v1alpha2/envbinding/envbinding_controller.go 52.00% <0.00%> (ø)
apis/standard.oam.dev/v1alpha1/register.go 100.00% <0.00%> (ø)
apis/core.oam.dev/v1alpha1/register.go 100.00% <0.00%> (ø)
pkg/utils/env/env.go 0.00% <0.00%> (ø)
...roller/core.oam.dev/v1alpha2/envbinding/binding.go 62.87% <0.00%> (ø)
apis/core.oam.dev/v1beta1/application_types.go 20.00% <0.00%> (ø)
pkg/appfile/config/store.go 0.00% <0.00%> (ø)
...is/core.oam.dev/condition/zz_generated.deepcopy.go 40.00% <0.00%> (ø)
... and 102 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7161959...8a7091e. Read the comment docs.

@wonderflow wonderflow merged commit 4eb8f1a into kubevela:master Jul 30, 2021
@Somefive Somefive deleted the suppress-log-during-import branch November 24, 2021 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getCPUInfo for OS darwin
2 participants