Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: workload namespace is empty while sync appdeployment #2009

Merged
merged 1 commit into from Aug 3, 2021
Merged

bugfix: workload namespace is empty while sync appdeployment #2009

merged 1 commit into from Aug 3, 2021

Conversation

shaowenchen
Copy link
Contributor

Signed-off-by: shaowenchen mail@chenshaowen.com

What this PR does / why we need it:

It raises an error Failed to reconcile appDeployment default/cross-cluster-app: cannot get object: an empty namespace may not be set when a resource name is provided when I test case refers to https://kubevela.io/docs/v1.1/end-user/scopes/appdeploy/#appdeployment

Signed-off-by: shaowenchen <mail@chenshaowen.com>
@shaowenchen
Copy link
Contributor Author

@yangsoon Can you help me to review this pr? This problem blocks my usage.

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #2009 (f3d25b7) into master (b4ebdac) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2009      +/-   ##
==========================================
+ Coverage   63.72%   63.84%   +0.11%     
==========================================
  Files         158      159       +1     
  Lines       14960    14973      +13     
==========================================
+ Hits         9533     9559      +26     
+ Misses       4452     4442      -10     
+ Partials      975      972       -3     
Flag Coverage Δ
e2e-rollout-tests 28.72% <0.00%> (+0.03%) ⬆️
e2etests 38.14% <0.00%> (+0.31%) ⬆️
unittests 59.25% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...v1alpha2/appdeployment/appdeployment_controller.go 53.51% <100.00%> (+0.18%) ⬆️
...dev/v1alpha2/initializer/initializer_controller.go 78.44% <0.00%> (-3.30%) ⬇️
...pha1/podspecworkload/podspecworkload_controller.go 6.89% <0.00%> (-0.05%) ⬇️
...ard.oam.dev/v1alpha1/rollout/rollout_controller.go 80.19% <0.00%> (ø)
.../core/scopes/healthscope/healthscope_controller.go 84.90% <0.00%> (ø)
...pplicationcontext/applicationcontext_controller.go 82.75% <0.00%> (ø)
...pplicationrollout/applicationrollout_controller.go 83.21% <0.00%> (ø)
...plicationconfiguration/applicationconfiguration.go 89.78% <0.00%> (ø)
pkg/controller/common/context.go 100.00% <0.00%> (ø)
...dev/v1alpha2/application/application_controller.go 83.95% <0.00%> (+0.08%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4ebdac...f3d25b7. Read the comment docs.

Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks

@wonderflow wonderflow merged commit af1e9dc into kubevela:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants