Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(rollout): improve rollback experience #2294

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

hongchaodeng
Copy link
Member

@hongchaodeng hongchaodeng commented Sep 14, 2021

Introduce canary-rollback step:

steps
- name: rollback
  type: canary-rollback

Users only need to apply this step and it will automatically rollback to the old version from previous rollout:


NAME         READY   UP-TO-DATE   AVAILABLE   AGE
reviews-v1   1/1
reviews-v2   1/1

NAME         READY   UP-TO-DATE   AVAILABLE   AGE
reviews-v1    2/2 
reviews-v2    0/0  

NAME         READY   UP-TO-DATE   AVAILABLE   AGE
reviews-v1   2/2 

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #2294 (d935fc4) into master (8407c0b) will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2294      +/-   ##
==========================================
- Coverage   63.47%   63.31%   -0.16%     
==========================================
  Files         164      164              
  Lines       16426    16426              
==========================================
- Hits        10426    10400      -26     
- Misses       4893     4909      +16     
- Partials     1107     1117      +10     
Flag Coverage Δ
e2e-rollout-tests 32.71% <ø> (-0.09%) ⬇️
e2etests 38.02% <ø> (-0.22%) ⬇️
unittests 55.81% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apis/core.oam.dev/v1beta1/policy_definition.go 0.00% <0.00%> (-50.00%) ⬇️
...erizedworkload/containerizedworkload_controller.go 60.41% <0.00%> (-8.34%) ⬇️
...m.dev/v1alpha1/envbinding/envbinding_controller.go 68.07% <0.00%> (-6.03%) ⬇️
...ponentdefinition/componentdefinition_controller.go 80.00% <0.00%> (-5.56%) ⬇️
...es/policydefinition/policydefinition_controller.go 62.82% <0.00%> (-3.85%) ⬇️
...dev/v1alpha2/application/application_controller.go 75.48% <0.00%> (-3.85%) ⬇️
...g/controller/core.oam.dev/v1alpha2/core/revison.go 71.73% <0.00%> (-2.18%) ⬇️
...ev/v1alpha2/core/scopes/healthscope/healthscope.go 67.42% <0.00%> (-1.31%) ⬇️
...ller/core.oam.dev/v1alpha2/application/revision.go 72.57% <0.00%> (-1.06%) ⬇️
...dev/v1alpha2/applicationconfiguration/component.go 58.26% <0.00%> (-0.79%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8407c0b...d935fc4. Read the comment docs.

@hongchaodeng hongchaodeng changed the title Feat(Rollout): Add rollout-approval step definition Feat(rollout): add rollout-approval step definition Sep 14, 2021
@hongchaodeng hongchaodeng changed the title Feat(rollout): add rollout-approval step definition Fix(rollout): improve rollback experience Sep 15, 2021
Copy link
Collaborator

@wangyikewxgm wangyikewxgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hongchaodeng hongchaodeng merged commit b60c16a into kubevela:master Sep 17, 2021
@hongchaodeng hongchaodeng deleted the rollout branch September 17, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants