Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: support terraform/provider-azure addon #2402

Merged
merged 1 commit into from Oct 8, 2021

Conversation

zzxwill
Copy link
Collaborator

@zzxwill zzxwill commented Sep 30, 2021

Also added some componentdefinitions for Azure cloud resource

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #2402 (fe6f876) into master (5767d16) will decrease coverage by 15.78%.
The diff coverage is 60.00%.

❗ Current head fe6f876 differs from pull request most recent head b1b101c. Consider uploading reports for the commit b1b101c to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2402       +/-   ##
===========================================
- Coverage   61.43%   45.64%   -15.79%     
===========================================
  Files         158      221       +63     
  Lines       16783    23096     +6313     
===========================================
+ Hits        10310    10543      +233     
- Misses       5360    11351     +5991     
- Partials     1113     1202       +89     
Flag Coverage Δ
e2e-multicluster-test 16.97% <0.00%> (-1.69%) ⬇️
e2e-rollout-tests ?
e2etests 37.18% <40.00%> (+0.15%) ⬆️
unittests 55.94% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/appfile/appfile.go 76.20% <33.33%> (-0.44%) ⬇️
apis/core.oam.dev/common/zz_generated.deepcopy.go 36.15% <100.00%> (+0.53%) ⬆️
...ntroller/common/rollout/rollout_plan_controller.go 1.53% <0.00%> (-62.57%) ⬇️
...ard.oam.dev/v1alpha1/rollout/rollout_controller.go 21.49% <0.00%> (-57.01%) ⬇️
apis/standard.oam.dev/v1alpha1/rollout_state.go 22.27% <0.00%> (-50.26%) ⬇️
...pplicationrollout/applicationrollout_controller.go 40.81% <0.00%> (-44.22%) ⬇️
...dev/v1alpha2/applicationrollout/rollout_handler.go 12.50% <0.00%> (-40.79%) ⬇️
....oam.dev/v1alpha2/applicationrollout/validation.go 42.55% <0.00%> (-19.15%) ⬇️
...troller/core.oam.dev/v1alpha2/application/apply.go 61.00% <0.00%> (-15.85%) ⬇️
...standard.oam.dev/v1alpha1/zz_generated.deepcopy.go 14.28% <0.00%> (-14.91%) ⬇️
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5767d16...b1b101c. Read the comment docs.

Also added some componentdefinitions for Azure cloud resource
@wonderflow wonderflow merged commit b8894b7 into kubevela:master Oct 8, 2021
@zzxwill zzxwill deleted the azure branch October 8, 2021 03:48
zzxwill added a commit to zzxwill/kubevela that referenced this pull request Oct 8, 2021
Also added some componentdefinitions for Azure cloud resource
wonderflow pushed a commit that referenced this pull request Oct 8, 2021
Also added some componentdefinitions for Azure cloud resource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants