Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: resourceTracker compatibility bug #2467

Merged
merged 1 commit into from Oct 13, 2021
Merged

Fix: resourceTracker compatibility bug #2467

merged 1 commit into from Oct 13, 2021

Conversation

wangyikewxgm
Copy link
Collaborator

@wangyikewxgm wangyikewxgm commented Oct 13, 2021

Description of your changes

Fix compatibility bug cause by fixing miss-spell resourceTracker label.

Fixes #2464

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #2467 (df5a802) into master (c3eaa74) will increase coverage by 0.15%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2467      +/-   ##
==========================================
+ Coverage   51.83%   51.98%   +0.15%     
==========================================
  Files         224      224              
  Lines       23321    23331      +10     
==========================================
+ Hits        12088    12129      +41     
+ Misses       9812     9787      -25     
+ Partials     1421     1415       -6     
Flag Coverage Δ
apiserver-unittests 25.53% <ø> (ø)
core-unittests 46.55% <80.00%> (+0.01%) ⬆️
e2e-multicluster-test 20.08% <40.00%> (+0.02%) ⬆️
e2e-rollout-tests 31.31% <40.00%> (+0.20%) ⬆️
e2etests 37.32% <40.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
....oam.dev/v1alpha2/application/dispatch/dispatch.go 77.32% <80.00%> (+1.39%) ⬆️
pkg/appfile/parser.go 66.96% <0.00%> (-1.77%) ⬇️
pkg/controller/utils/capability.go 79.85% <0.00%> (-1.47%) ⬇️
pkg/appfile/template.go 55.88% <0.00%> (-0.85%) ⬇️
...am.dev/v1alpha2/applicationconfiguration/render.go 87.39% <0.00%> (-0.82%) ⬇️
pkg/oam/util/helper.go 73.90% <0.00%> (+0.48%) ⬆️
...ller/core.oam.dev/v1alpha2/application/revision.go 73.48% <0.00%> (+0.75%) ⬆️
...troller/core.oam.dev/v1alpha2/application/apply.go 79.31% <0.00%> (+0.98%) ⬆️
...ler/core.oam.dev/v1alpha2/application/generator.go 79.24% <0.00%> (+1.88%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3eaa74...df5a802. Read the comment docs.

make reivwable
@wonderflow wonderflow merged commit 4956d0e into kubevela:master Oct 13, 2021
@github-actions
Copy link

Successfully created backport PR #2470 for release-1.1.

@wonderflow wonderflow changed the title Fix: compatibility bug Fix: resourceTracker compatibility bug Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ResourceTracker list compatibility bug
2 participants