Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: aws/azure Terraform provider are broken #2517

Merged
merged 1 commit into from Oct 19, 2021

Conversation

zzxwill
Copy link
Collaborator

@zzxwill zzxwill commented Oct 19, 2021

Removed built-in aws/azure Terraform providers, and fix azure
mariadb definition issue.

Fix #2475

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Removed built-in aws/azure Terraform providers, and fix azure
mariadb definition issue.

Fix kubevela#2475
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #2517 (7fdbeff) into release-1.1 (eb5808e) will increase coverage by 4.63%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.1    #2517      +/-   ##
===============================================
+ Coverage        44.59%   49.23%   +4.63%     
===============================================
  Files              219      219              
  Lines            23431    23431              
===============================================
+ Hits             10450    11536    +1086     
+ Misses           11772    10624    -1148     
- Partials          1209     1271      +62     
Flag Coverage Δ
e2e-multicluster-test 17.54% <ø> (-0.01%) ⬇️
e2e-rollout-tests 30.12% <ø> (-0.03%) ⬇️
e2etests 37.97% <ø> (?)
unittests 55.49% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apis/core.oam.dev/v1beta1/policy_definition.go 0.00% <0.00%> (-50.00%) ⬇️
...es/policydefinition/policydefinition_controller.go 60.25% <0.00%> (-6.42%) ⬇️
...aits/traitdefinition/traitdefinition_controller.go 65.26% <0.00%> (-5.27%) ⬇️
...m.dev/v1alpha1/envbinding/envbinding_controller.go 69.27% <0.00%> (-3.62%) ⬇️
pkg/cue/definition/template.go 59.05% <0.00%> (ø)
...dev/v1alpha2/applicationconfiguration/component.go 59.05% <0.00%> (+0.78%) ⬆️
apis/standard.oam.dev/v1alpha1/rollout_state.go 72.53% <0.00%> (+1.03%) ⬆️
...plicationconfiguration/applicationconfiguration.go 88.58% <0.00%> (+1.20%) ⬆️
...core.oam.dev/v1alpha2/applicationrollout/helper.go 83.75% <0.00%> (+1.25%) ⬆️
pkg/workflow/workflow.go 83.80% <0.00%> (+1.40%) ⬆️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb5808e...7fdbeff. Read the comment docs.

@wonderflow wonderflow merged commit 516156f into kubevela:release-1.1 Oct 19, 2021
@zzxwill zzxwill deleted the release-1.1-terraform branch November 11, 2021 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants