Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add list application records api #2757

Merged
merged 4 commits into from Nov 21, 2021

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Nov 20, 2021

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Nov 21, 2021

Codecov Report

Merging #2757 (2147ee6) into apiserver (0fedad7) will increase coverage by 5.88%.
The diff coverage is 51.86%.

Impacted file tree graph

@@              Coverage Diff              @@
##           apiserver    #2757      +/-   ##
=============================================
+ Coverage      21.82%   27.71%   +5.88%     
=============================================
  Files            128      148      +20     
  Lines          10866    13928    +3062     
=============================================
+ Hits            2372     3860    +1488     
- Misses          8011     9386    +1375     
- Partials         483      682     +199     
Flag Coverage Δ
apiserver-unittests 27.71% <51.86%> (+5.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apis/core.oam.dev/common/types.go 14.28% <ø> (ø)
apis/core.oam.dev/v1alpha1/envbinding_types.go 0.00% <0.00%> (ø)
...pis/core.oam.dev/v1alpha1/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
...s/core.oam.dev/v1beta1/workflow_step_definition.go 0.00% <ø> (ø)
apis/types/capability.go 0.00% <ø> (ø)
pkg/apiserver/datastore/datastore.go 66.66% <ø> (ø)
pkg/apiserver/model/addon.go 100.00% <ø> (ø)
pkg/apiserver/rest/apis/v1/types.go 0.00% <0.00%> (ø)
pkg/apiserver/rest/utils/bcode/addon.go 0.00% <0.00%> (ø)
pkg/apiserver/rest/utils/params.go 33.33% <0.00%> (ø)
... and 101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8181b4d...2147ee6. Read the comment docs.

@barnettZQG barnettZQG merged commit 32103f5 into kubevela:apiserver Nov 21, 2021
@FogDong FogDong deleted the feat-apprecords branch June 30, 2022 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants