-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add workflow reconciling backoff time and failed limit times #2881
Conversation
aedf668
to
4ac8e5d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2881 +/- ##
===========================================
+ Coverage 47.21% 60.00% +12.78%
===========================================
Files 173 239 +66
Lines 17669 24430 +6761
===========================================
+ Hits 8343 14659 +6316
+ Misses 8353 8015 -338
- Partials 973 1756 +783
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
4ac8e5d
to
dd8fe0c
Compare
|
你说的这种可能是 controller runtime 的 backoff 机制,系数 0.005*2^(n-1),若结果小于 1 则以 1 为最小单位
但在我们的场景里,workflow step 失败了 10 次或是 50 次的结果应该是差不多的,如果觉得 5 次重试太少,可以更改为 10 次。
WDYT /cc @wonderflow @leejanee |
这样可以的,不过系数可以放大一点,错误发生时没必要追求快速重试的 |
This table works fine for me, please make the retry time at least to be 20 times, the last 8 times retry can be 1 min .
|
pkg/controller/core.oam.dev/v1alpha2/application/application_controller.go
Outdated
Show resolved
Hide resolved
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
4fc17b4
to
b34e100
Compare
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
另外,reconcile backoff不单单服务于流水线,甚至涉及到gc机制。这里一定要协调好,如果发生冲突可能需要以最短的时间为准
pkg/controller/core.oam.dev/v1alpha2/application/application_controller.go
Outdated
Show resolved
Hide resolved
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
pkg/controller/core.oam.dev/v1alpha2/application/application_controller.go
Outdated
Show resolved
Hide resolved
pkg/controller/core.oam.dev/v1alpha2/application/application_controller.go
Outdated
Show resolved
Hide resolved
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
pkg/controller/core.oam.dev/v1alpha2/application/application_controller.go
Outdated
Show resolved
Hide resolved
pkg/controller/core.oam.dev/v1alpha2/application/application_controller.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after nits
pkg/controller/core.oam.dev/v1alpha2/application/application_controller.go
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
Description of your changes
This PR:
The workflow is now running like this:
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer
/cc @leejanee