Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: set multicluster enabled by default #2930

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

Somefive
Copy link
Collaborator

Signed-off-by: Yin Da yd219913@alibaba-inc.com

Description of your changes

Set multi-cluster as enabled by default in kubevela chart.
NOTE: minimal chart still keep it disabled by default

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #2930 (7148edf) into master (4dc2134) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2930   +/-   ##
=======================================
  Coverage   59.81%   59.82%           
=======================================
  Files         239      239           
  Lines       24280    24280           
=======================================
+ Hits        14524    14525    +1     
+ Misses       8007     8003    -4     
- Partials     1749     1752    +3     
Flag Coverage Δ
apiserver-unittests 27.44% <ø> (+0.03%) ⬆️
core-unittests 47.04% <ø> (+0.01%) ⬆️
e2e-multicluster-test 24.90% <ø> (ø)
e2e-rollout-tests 28.83% <ø> (+0.18%) ⬆️
e2etests 37.66% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apis/core.oam.dev/v1beta1/policy_definition.go 0.00% <0.00%> (-50.00%) ⬇️
...aits/traitdefinition/traitdefinition_controller.go 63.15% <0.00%> (-9.48%) ⬇️
...g/controller/core.oam.dev/v1alpha2/core/revison.go 71.73% <0.00%> (-2.18%) ⬇️
...ntroller/common/rollout/rollout_plan_controller.go 60.51% <0.00%> (-1.54%) ⬇️
...am.dev/v1alpha2/applicationconfiguration/render.go 87.39% <0.00%> (-0.82%) ⬇️
...es/policydefinition/policydefinition_controller.go 66.66% <0.00%> (ø)
pkg/oam/util/helper.go 76.09% <0.00%> (+0.48%) ⬆️
...ller/core.oam.dev/v1alpha2/application/revision.go 74.90% <0.00%> (+0.98%) ⬆️
...dev/v1alpha2/application/application_controller.go 77.69% <0.00%> (+3.07%) ⬆️
pkg/apiserver/rest/utils/bcode/bcode.go 46.66% <0.00%> (+3.33%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dc2134...7148edf. Read the comment docs.

Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@wonderflow wonderflow merged commit a3bf61f into kubevela:master Dec 15, 2021
@Somefive Somefive deleted the set_multicluster_default branch June 20, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants