Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disable installation of builtin capabilities #687

Merged
merged 3 commits into from Dec 4, 2020

Conversation

zzxwill
Copy link
Collaborator

@zzxwill zzxwill commented Dec 1, 2020

Added vela core bootstrap flag --enable-caps to support no
installation for builtin capabilities

Feature #658

@zzxwill
Copy link
Collaborator Author

zzxwill commented Dec 1, 2020

@wonderflow I changed flag --disable-cap to --enable-caps at last.
Reasons:

  • Using value none can also support disabling all builtin controllers. (By default, value all will support enabling all capabilities.)
  • It will be easier to set the value for the flag if platform builders want to enable one or more builtin capabilities one day.
    For example, there are four capabilities "metrics", "podspecworkload", "route", "autoscale", if builders want to disable metrics, we have to set --disable-caps=podspecworkload,route,autoscale. But now, we can just set --enable-caps=metrics. It seems straighter.

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #687 (6852c68) into master (af5bdd7) will increase coverage by 0.52%.
The diff coverage is 46.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #687      +/-   ##
==========================================
+ Coverage   34.05%   34.57%   +0.52%     
==========================================
  Files          82       91       +9     
  Lines        7577     8015     +438     
==========================================
+ Hits         2580     2771     +191     
- Misses       4738     4946     +208     
- Partials      259      298      +39     
Flag Coverage Δ
unittests 34.57% <46.37%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/core/main.go 21.23% <0.00%> (-0.76%) ⬇️
pkg/application/app.go 26.54% <0.00%> (ø)
pkg/commands/cli.go 0.00% <0.00%> (ø)
pkg/commands/export.go 0.00% <0.00%> (ø)
pkg/commands/up.go 15.87% <0.00%> (-1.52%) ⬇️
...ore.oam.dev/v1alpha2/application/parser/decoder.go 0.00% <0.00%> (ø)
...m.dev/v1alpha1/autoscaler/autoscaler_controller.go 0.00% <0.00%> (ø)
...oller/standard.oam.dev/v1alpha1/autoscaler/keda.go 0.00% <ø> (ø)
pkg/appfile/appfile.go 76.11% <25.00%> (+3.26%) ⬆️
....oam.dev/v1alpha2/application/template/template.go 26.92% <26.92%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af5bdd7...12ba05e. Read the comment docs.

cmd/core/main.go Outdated Show resolved Hide resolved
cmd/core/main.go Outdated Show resolved Hide resolved
@zzxwill zzxwill force-pushed the feature-pure-runtime branch 2 times, most recently from be66857 to 2e6b967 Compare December 2, 2020 08:02
cmd/core/main.go Outdated Show resolved Hide resolved
Added vela core bootstrap flag `--enable-caps` to support no
installation for builtin capabiliteis

Feature kubevela#658
@zzxwill zzxwill force-pushed the feature-pure-runtime branch 2 times, most recently from 1fed24d to 59d4f88 Compare December 3, 2020 07:17
Co-authored-by: Jianbo Sun <wonderflow.sun@gmail.com>
pkg/webhook/register.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wonderflow wonderflow merged commit 06585fe into kubevela:master Dec 4, 2020
@zzxwill zzxwill deleted the feature-pure-runtime branch February 1, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants