Implement API for generating OpenAPI schema for definition #784

zzxwill · 2020-12-18T02:22:50Z

Fetched cue parameters from workloaddefinition/traitdefinition, generated
OpenAPI v3 schema, fixed problems of tainted description filed, added filed
"title" required by form-render component, added it in API server router

To fix #680

codecov · 2020-12-21T09:30:36Z

Codecov Report

Merging #784 (a9a419d) into master (810cbca) will increase coverage by 0.24%.
The diff coverage is 51.79%.

@@            Coverage Diff             @@
##           master     #784      +/-   ##
==========================================
+ Coverage   35.94%   36.19%   +0.24%     
==========================================
  Files         103      105       +2     
  Lines        8668     8821     +153     
==========================================
+ Hits         3116     3193      +77     
- Misses       5192     5252      +60     
- Partials      360      376      +16

Flag	Coverage Δ
unittests	`36.19% <51.79%> (+0.24%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/core/main.go	`20.66% <0.00%> (-0.28%)`	⬇️
pkg/appfile/service.go	`70.50% <ø> (ø)`
...plicationconfiguration/applicationconfiguration.go	`83.95% <0.00%> (-0.35%)`	⬇️
...dev/v1alpha2/applicationconfiguration/component.go	`71.65% <0.00%> (ø)`
.../core/scopes/healthscope/healthscope_controller.go	`75.23% <ø> (ø)`
.../manualscalertrait/manualscalertrait_controller.go	`0.00% <ø> (ø)`
...erizedworkload/containerizedworkload_controller.go	`0.00% <ø> (ø)`
pkg/serverlib/definition.go	`43.15% <43.15%> (ø)`
pkg/utils/common/common.go	`58.49% <81.81%> (ø)`
...licationconfiguration/component_custom_revision.go	`63.63% <100.00%> (+53.63%)`	⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 810cbca...da09798. Read the comment docs.

go.mod

pkg/server/definitionHandler.go

pkg/utils/common/common.go

pkg/server/definitionHandler_test.go

pkg/server/definitionHandler.go

wonderflow

review了一半，感觉我前面的review似乎都没改？

.gitignore

pkg/serverlib/definition.go

Fetched cue parameters from workloaddefinition/traitdefinition, generated OpenAPI v3 schema, fixed problems of tainted `description` filed, added filed "title" required by form-render component, added it in API server router To fix kubevela#680

wonderflow · 2021-01-06T02:18:21Z

Much better now, ping @hongchaodeng to do one more round review.

ryanzhang-oss · 2021-01-06T02:23:40Z

One question, does this still work if we move this to the serverside (no local files)?

zzxwill · 2021-01-06T02:25:51Z

One question, does this still work if we move this to the serverside (no local files)?

No, currently it heavily depends on the local ~/.vela folder.

wonderflow · 2021-01-06T02:28:32Z

@zzxwill we should use a storage interface to do so, just like #751

hongchaodeng

lgtm with one minor comment

pkg/appfile/service.go

Co-authored-by: Hongchao Deng <hongchaodeng1@gmail.com>

zzxwill force-pushed the form-render branch from 274cce6 to 35a94bc Compare December 21, 2020 07:44

zzxwill marked this pull request as ready for review December 21, 2020 08:39

zzxwill force-pushed the form-render branch from fe3753b to f2403ce Compare December 21, 2020 09:36

zzxwill changed the title ~~[WIP] Implement API for generating OpenAPI schema for definition~~ Implement API for generating OpenAPI schema for definition Dec 21, 2020

zzxwill force-pushed the form-render branch from f2403ce to f731b15 Compare December 21, 2020 09:49

wonderflow reviewed Dec 21, 2020

View reviewed changes

pkg/server/definitionHandler.go Show resolved Hide resolved

zzxwill force-pushed the form-render branch 3 times, most recently from ff273cf to 6721724 Compare December 23, 2020 02:57

wonderflow reviewed Dec 23, 2020

View reviewed changes