Add "description" field for each workload from ListWorkloads API #824
Conversation
Codecov Report
@@ Coverage Diff @@
## master #824 +/- ##
==========================================
+ Coverage 35.92% 35.98% +0.05%
==========================================
Files 99 99
Lines 8656 8656
==========================================
+ Hits 3110 3115 +5
+ Misses 5199 5196 -3
+ Partials 347 345 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Workload item doesn't have descriptin property, added it to help display the description in capability list on Dashboard
zzxwill
force-pushed
the
issue-workloads
branch
from
28b7ba6
to
37cb5cc
Compare
| @@ -47,9 +47,9 @@ type WorkloadRunBody struct { | |||
|
|
|||
| // WorkloadMeta store workload metadata for dashboard restful API server | |||
| type WorkloadMeta struct { | |||
| Name string `json:"name"` | |||
| Parameters []types.Parameter `json:"parameters,omitempty"` | |||
| AppliesTo []string `json:"appliesTo,omitempty"` | |||
There was a problem hiding this comment.
BTW, it's better to have a unit test for it. Now, even we delete some field(which should be a break change) that the CI won't fail.
There was a problem hiding this comment.
Workload should not have AppliesTo field. And I have confirmed all callers of this struct and it's only called by pkg/server/workloadHandler.go.
Workload item doesn't have descriptin property, added it to help display
the description in capability list on Dashboard
Fix #821