New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
display trait status information with customized style #975
Conversation
Codecov Report
@@ Coverage Diff @@
## master #975 +/- ##
==========================================
+ Coverage 37.66% 38.33% +0.66%
==========================================
Files 114 114
Lines 9557 9556 -1
==========================================
+ Hits 3600 3663 +63
+ Misses 5506 5422 -84
- Partials 451 471 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dc21fd1
to
f686412
Compare
a59e2a8
to
e8cefa0
Compare
@@ -49,6 +49,24 @@ type AppStatus struct { | |||
|
|||
// Components record the related Components created by Application Controller | |||
Components []runtimev1alpha1.TypedReference `json:"components,omitempty"` | |||
|
|||
// Services record the status of the application services | |||
Services []ApplicationComponentStatus `json:"services,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename to "componentStatus"? I think it might also good to fold this to the "Components"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Components is occupied, componentStatus not very good name
} | ||
workloadCr, err := getObj(client, componentWorkload, name) | ||
// workload main resource will have a unique label("app.oam.dev/resourceType"="WORKLOAD") in per component/app level | ||
object, err := getResourceFromObj(componentWorkload, cli, ns, util.MergeMapOverrideWithDst(map[string]string{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't fully understand this. The object is not emitted to the K8s yet, how can we get the object through the client?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this stage, the resource has already ommited to K8s, just like health check
// AbstractEngine defines Definition's Render interface | ||
type AbstractEngine interface { | ||
Params(params interface{}) AbstractEngine | ||
Complete(ctx process.Context, abstractTemplate string) error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
normally, we complete something given the "parameter" instead of the template. Am I missing something?
e8cefa0
to
8ff8128
Compare
…health check code
8ff8128
to
f310665
Compare
07c4bf2
to
14a4f3a
Compare
14a4f3a
to
87e52bb
Compare
c42daf4
to
868e092
Compare
fix #885
part of #877
appName added in context, part of #951
Usage: