Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report which OS release was detected as unsupported #1235

Merged
merged 1 commit into from
May 16, 2024

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented May 16, 2024

includes #1234 to prevent merge conflicts

@pirat89
Copy link
Member

pirat89 commented May 16, 2024

@evgeni lgtm. I like it. But thinking about that, when you already started these changes, that we could add also remediation instructions, somthing like:

pkg_manager = 'yum' if version.get_source_major_version == '7' else 'dnf
reporting.Remediation(hint=(
    'Update your system using {pkg_manager} to the version of the system supported for the in-place upgrade.'
    .format(pkg_manager=pkg_manager)
))

@pirat89 pirat89 added this to the 8.10/9.5 milestone May 16, 2024
@pirat89 pirat89 added the report Any reports have been added / removed / changed in the PR label May 16, 2024
@evgeni
Copy link
Member Author

evgeni commented May 16, 2024

Personally, I wouldn't do that.
The unsupported systems will be Alma, Rocky etc, and they can't be upgraded using dnf, so posting that remediation would be wrong

@pirat89
Copy link
Member

pirat89 commented May 16, 2024

Interesting. Oki, let's skip it for now. It can be added later, e.g. with the check the system is rhel.

@pirat89 pirat89 merged commit 8ad0245 into oamg:master May 16, 2024
13 checks passed
@evgeni evgeni deleted the report-detected-os branch May 16, 2024 17:16
@evgeni
Copy link
Member Author

evgeni commented May 16, 2024

Maybe the "will" was too hard, but certainly "could" until we allow them properly.

@pirat89
Copy link
Member

pirat89 commented May 17, 2024

well, when we add check for the rhel system, then we can clearly skip this whole report from my pov. e.g. for centos stream this report does not provide any value at all. and I have no idea about requirements from almalinux/rocky at all. so from my pov, it's matter of time we update this particular actor. but it's for me interesting that almalinux could not use yum/dnf for the update of the system. that's for me hoenstly little bit weird. so I guess I am missing here something.

@evgeni
Copy link
Member Author

evgeni commented May 17, 2024

Can you use yum/dnf to upgrade RHEL from 8 to 9? Alma/Rocky/Oracle has the same issue. You gotta Leapp major versions.

@pirat89
Copy link
Member

pirat89 commented May 17, 2024

no, but you can use DNF do update to newer minor version. This is about trying to upgrade FROM unsupported version of the system.

@evgeni
Copy link
Member Author

evgeni commented May 17, 2024

Ooooh. Now I get what you wanted to do!

if (on 8.9) {
    tell user to update to 8.10 first using dnf
}

I've read it as "we do not support this OS, use dnf for the major upgrade instead"

Damn, I should read less comments on tiny smartphone screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
report Any reports have been added / removed / changed in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants