Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Directory for an actor to store extra data that is managed by leapp #775

Open
fernflower opened this issue Dec 8, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@fernflower
Copy link
Member

Some actors may require to store additional information during the upgrade, which can be too big to put in the leapp-report files as is (example - the selinux actor and failed modules https://github.com/oamg/leapp-repository/pull/749/files#diff-7b3410d4a2f5284d190fcacc1cd90255b792a10baef32d37629158586277ffccR167-R170 )
Having this managed by actors themselves is not wise as those self-managed additional data files won't be archived\cleaned up in between runs together with other leapp logs - this situation is an invitation to fun debugging.

We could add some framework level LEAPP_BACKUP_DIR in the config with the possibility to override with a relevant env var, with '`/var/lib/leapp/backup' by default.

@vinzenz
Copy link
Member

vinzenz commented Dec 8, 2021

Backup is handled by the cli commands themselves

@vinzenz vinzenz transferred this issue from oamg/leapp Dec 8, 2021
@fernflower
Copy link
Member Author

@vinzenz 'backup' is probably a bad naming for the matter. It should be 'extra_actor_report_data' or smth. Some leapp-managed directory that will survive the upgrade and have actor-specific information stored so that we could actually include a path to those files in a report. Like https://github.com/oamg/leapp-repository/pull/749/files#diff-7b3410d4a2f5284d190fcacc1cd90255b792a10baef32d37629158586277ffccR167-R170

@pirat89
Copy link
Member

pirat89 commented Dec 14, 2021

Something like extra_resources or extra_actor_data sounds good to me. But we have to think about policies to store data inside. E.g.

  • provide API to be able to store files inside?
  • what will be the hierarchy? (we need to be sure that various actors are not randomly changing content created by a different actors; so e.g. /var/lib/leapp//extra/{repository}/{actorname}/... (probably not good, but for thinking.. also it could reflect dir strcture (path) inside repositories, so it could be like an extension of the private files for actors - if you know what I mean.)
  • do we want to actors to read the content created by other actors? - i vote for the private policy. actor that created the content can read it, but for otheractors it should be unknown content. could be handled by API functions.

@pirat89 pirat89 changed the title [feature] Directory for custom actor backup data that is managed by leapp [feature] Directory for an actor to store extra data that is managed by leapp Dec 14, 2021
@pirat89 pirat89 added the enhancement New feature or request label Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants